From nobody Sat Apr 20 14:39:06 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VMDgN6vbSz5Hv5c for ; Sat, 20 Apr 2024 14:39:44 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VMDgN6hG0z4hLp for ; Sat, 20 Apr 2024 14:39:44 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713623984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zg6AgsJ8po5Mz+DYo5+s2vgjT38+XetsUKBuGrFc3X0=; b=qdNLAa5HRVnK6yoMrMP2GpNVViTbi1SQbkt9zuAadRxkJhKpAziCp6AA5AjwvTbiu4XwVx UIkemFs61Pp5a3R+Qlh1QtPkVf3oXO7zFbkHLBGEaglhIGG0koiBZbKsOnWqNf/1cLvvHj Q+BXYvLLG0nsWP7Bd24riOaO60nzsM8CENTurqp03dfjBBcwKmsFtqXmAgSFqLhFnGFZGo cQMilZqN1br8sip4PolAwxSXHTiEAeRffYvyr1vb251Ba0brNZVxLuj2qsVn2zHMrBfLoo teW+dvX9zPbu5o1kXt25cKBdWMM6qVUe/9Z3+H6aAlhm2tokmWqTLTVVVp09rQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713623984; a=rsa-sha256; cv=none; b=KPx3bHDHfDHx+eG9ABzRhHKgh53fk2DNUHQz+btAtviK/mgRoy+mPQSE8L6IiVy7ntzPla RCw2aOZOP54OF9YomFjdUsIu+zMSL/EophHDmIDhnEyuKuLoxOa4/0QiiO+Ks0EiNVRXz5 Vyya5axH87DnkEKVU740aQWO6aaGYmnzRPN+qU97ez/uF5X3ozwbi8Q7j0GxlHYEdK+OKB KrRjO/bkFvd2QR17XBo6TRH0NAkRLc0RMciU3f6pGR79Q8SctcEN4rwKrsrA6yhA2vtGcR o5rPRONeKROd/mPGZCbv740ONZfjzfu+1xN60w+7X0TmQyt4Zuy0ZCD/g4/FNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713623984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zg6AgsJ8po5Mz+DYo5+s2vgjT38+XetsUKBuGrFc3X0=; b=wgNSTDY0ERo7qoimMY59sCpW1enB9U4hDoQtD4eOb7lgjV5E4f72nzwhpjTBWgzQ4Rfvtd ONGycRY7Z+YVtdXtjblu9bSF8bk3QhretGIuDON2jCr9+i0/DtyXrz6uzpy/PwUFlmE0qj lu+nyzFFlTLxGHRW7wFWV+6Kt+J1ZHO6gH7GXBnCnfHhFDLuYZDds9EHOcCpYrjo7xabxB tOVyyC1823jtwMn1dODCgYsZp5kdpeKMMtKE/bfjnSe8trVHHSuUd9xW8eBeEepdxDKvEB JHoqnfZgTZ9FwRveuoDTSykbgY7W540mn+5RQH30bGgprC37e6OQDZjQ2fw1jw== Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VMDgN60lKz1Mn9 for ; Sat, 20 Apr 2024 14:39:44 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a523524e5baso305833866b.3 for ; Sat, 20 Apr 2024 07:39:44 -0700 (PDT) X-Gm-Message-State: AOJu0YxtrsN8ycO/NTiw48gd/v4dXxh+nqyaA29bst+kXdWPYK0Cev3z rGs76i6aqybYd3A4b3W8u31fjZYEMbzpjo4fYxzKoNiwTyHAXVD7nf/UJI4sgnJqnlsTXZ2xrog bcuTT+K5KXMMNri4oIoBj22vC9mL6L6R70Zi4aA== X-Google-Smtp-Source: AGHT+IFy8P+2eE90kD+cuvGazkXkioAFs+VeDGV9lSt+Bg66WjU/DyqoUjr4332n0PU1YCmJjNCzEdqE87LfvgRBVTk= X-Received: by 2002:a17:906:4a8a:b0:a52:8062:a8d0 with SMTP id x10-20020a1709064a8a00b00a528062a8d0mr4220571eju.58.1713623983599; Sat, 20 Apr 2024 07:39:43 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202404181253.43ICr61o069768@gitrepo.freebsd.org> <28fe5b36-8136-44b7-b08f-fe3b653d60d3@freebsd.org> In-Reply-To: <28fe5b36-8136-44b7-b08f-fe3b653d60d3@freebsd.org> From: Po-Chuan Hsieh Date: Sat, 20 Apr 2024 22:39:06 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: e710744f6c83 - main - graphics/GraphicsMagick: Update to 1.3.43 To: Vladimir Druzenko Cc: dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d254030616882c3b" --000000000000d254030616882c3b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 12:21=E2=80=AFAM Vladimir Druzenko wrote: > 18.04.2024 15:53, Po-Chuan Hsieh =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3De710744f6c835f2b99cbfca56d523= d46109e63b0 > > > > commit e710744f6c835f2b99cbfca56d523d46109e63b0 > > Author: Po-Chuan Hsieh > > AuthorDate: 2024-04-18 12:47:58 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2024-04-18 12:47:58 +0000 > > > > graphics/GraphicsMagick: Update to 1.3.43 > > > > Changes: http://www.graphicsmagick.org/NEWS.html > > --- > > graphics/GraphicsMagick/Makefile | 5 +- > > graphics/GraphicsMagick/distinfo | 6 +-- > > graphics/GraphicsMagick/files/patch-Makefile.in | 11 ---- > > graphics/GraphicsMagick/files/patch-coders_jxl.c | 63 > ---------------------- > > graphics/GraphicsMagick/files/patch-configure | 28 +++------- > > graphics/GraphicsMagick/files/patch-jpeg-turbo | 67 > ------------------------ > > graphics/GraphicsMagick/pkg-plist | 11 ++-- > > 7 files changed, 20 insertions(+), 171 deletions(-) > > > > diff --git a/graphics/GraphicsMagick/Makefile > b/graphics/GraphicsMagick/Makefile > > index be2ef664e5cf..98b9b182def1 100644 > > --- a/graphics/GraphicsMagick/Makefile > > +++ b/graphics/GraphicsMagick/Makefile > > @@ -1,6 +1,5 @@ > > PORTNAME=3D GraphicsMagick > > -PORTVERSION=3D 1.3.40 > > -PORTREVISION=3D 5 > > +PORTVERSION=3D 1.3.43 > > PORTEPOCH=3D 1 > > CATEGORIES=3D graphics > > MASTER_SITES=3D SF > > @@ -11,7 +10,7 @@ WWW=3D http://www.graphicsmagick.org/ > > > > LICENSE=3D MIT > > > > -USES=3D cpe libtool localbase pathfix pkgconfig tar:zst > > +USES=3D cpe libtool localbase pathfix pkgconfig tar:xz > > > > CONFIGURE_ARGS=3D --enable-shared --enable-static \ > > --with-windows-font-dir=3D${WINDOWS_FONT_DIR} \ > > Hello! > > Build fails with FPX option on: > > > libtool: link: cc -fopenmp -O2 -pipe -march=3Dnehalem > > -fstack-protector-strong -isystem /usr/local/include > > -fno-strict-aliasing -Wall -D_THREAD_SAFE -fstack-protector-strong > > -fstack-protector-strong -o utilities/.libs/gm utilities/gm.o > > -L/usr/local/lib magick/.libs/libGraphicsMagick.so -ljasper -lwmflite > > -ljxl -ljxl_threads -ltiff -ljbig -lsharpyuv -lwebp -lwebpmux > > -lfreetype -ljpeg -lpng16 -llcms2 -llcms2_fast_float -llcms2_threaded > > -lXext -lSM -lICE -lX11 -lxml2 -llzma -lbz2 -lz -lm -lpthread -lomp > > -fopenmp -Wl,-rpath -Wl,/usr/local/lib > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_InitSystem > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetToolkitMemoryLimit > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ClearSystem > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_OpenImageByFilename > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_GetSummaryInformation > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_GetImageResultAspectRatio > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_CloseImage > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetResampleMethod > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ReadImageRectangle > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ReadImageTransformRectangle > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_CreateImageByFilename > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetJPEGCompression > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetSummaryInformation > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_WriteImageLine > > >>> referenced by magick/.libs/libGraphicsMagick.so > > cc: error: linker command failed with exit code 1 (use -v to see > > invocation) > > *** [utilities/gm] Error code 1 > > > Fixed with patch: > -USES=3D cpe libtool localbase pathfix pkgconfig tar:xz > +USES=3D cpe libtool localbase:ldflags pathfix pkgconfig tar:xz > +FPX_LDFLAGS=3D -lfpx > > Tested on 13.3-p1 amd64 in poudriere and on live system. > > If you agree I can commit self. > > -- > Best regards, > Vladimir Druzenko > Fixed in ports f57677209d3a6981cbb5e2bceba03c37ea2f65a8. Thanks. However, I'd like to remove it. I wonder if people really use fpx nowadays. --000000000000d254030616882c3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 19, 2024 at 12:21=E2=80=AFAM = Vladimir Druzenko <vvd@freebsd.org> wrote:
18.04.2024 15:53, Po-Chuan Hsieh =D0=BF=D0=B8=D1=88= =D0=B5=D1=82:
> The branch main has been updated by sunpoet:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3De710744f6c835f2b99cbfca56d523d46109e6= 3b0
>
> commit e710744f6c835f2b99cbfca56d523d46109e63b0
> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2024-04-18 12:47:58 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2024-04-18 12:47:58 +0000
>
>=C2=A0 =C2=A0 =C2=A0 graphics/GraphicsMagick: Update to 1.3.43
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 = http://www.graphicsmagick.org/NEWS.html
> ---
>=C2=A0 =C2=A0graphics/GraphicsMagick/Makefile=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 +-
>=C2=A0 =C2=A0graphics/GraphicsMagick/distinfo=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +--
>=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-Makefile.in=C2=A0 | 11= ----
>=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-coders_jxl.c | 63 ----= ------------------
>=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-configure=C2=A0 =C2=A0= | 28 +++-------
>=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-jpeg-turbo=C2=A0 =C2= =A0| 67 ------------------------
>=C2=A0 =C2=A0graphics/GraphicsMagick/pkg-plist=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 11 ++--
>=C2=A0 =C2=A07 files changed, 20 insertions(+), 171 deletions(-)
>
> diff --git a/graphics/GraphicsMagick/Makefile b/graphics/GraphicsMagic= k/Makefile
> index be2ef664e5cf..98b9b182def1 100644
> --- a/graphics/GraphicsMagick/Makefile
> +++ b/graphics/GraphicsMagick/Makefile
> @@ -1,6 +1,5 @@
>=C2=A0 =C2=A0PORTNAME=3D=C2=A0 =C2=A0GraphicsMagick
> -PORTVERSION=3D 1.3.40
> -PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 5
> +PORTVERSION=3D 1.3.43
>=C2=A0 =C2=A0PORTEPOCH=3D=C2=A0 1
>=C2=A0 =C2=A0CATEGORIES=3D graphics
>=C2=A0 =C2=A0MASTER_SITES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0SF
> @@ -11,7 +10,7 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 http://www.graphicsmagick.org/
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0LICENSE=3D=C2=A0 =C2=A0 MIT
>=C2=A0 =C2=A0
> -USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe li= btool localbase pathfix pkgconfig tar:zst
> +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe li= btool localbase pathfix pkgconfig tar:xz
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0--enable-shared --ena= ble-static \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-windows-f= ont-dir=3D${WINDOWS_FONT_DIR} \

Hello!

Build fails with FPX option on:

> libtool: link: cc -fopenmp -O2 -pipe -march=3Dnehalem
> -fstack-protector-strong -isystem /usr/local/include
> -fno-strict-aliasing -Wall -D_THREAD_SAFE -fstack-protector-strong > -fstack-protector-strong -o utilities/.libs/gm utilities/gm.o=C2=A0 > -L/usr/local/lib magick/.libs/libGraphicsMagick.so -ljasper -lwmflite =
> -ljxl -ljxl_threads -ltiff -ljbig -lsharpyuv -lwebp -lwebpmux
> -lfreetype -ljpeg -lpng16 -llcms2 -llcms2_fast_float -llcms2_threaded =
> -lXext -lSM -lICE -lX11 -lxml2 -llzma -lbz2 -lz -lm -lpthread -lomp > -fopenmp -Wl,-rpath -Wl,/usr/local/lib
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_InitSystem
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_SetToolkitMemoryLimit
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_ClearSystem
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_OpenImageByFilename
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_GetSummaryInformation
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_GetImageResultAspectRatio
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_CloseImage
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_SetResampleMethod
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_ReadImageRectangle
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_ReadImageTransformRectangle
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_CreateImageByFilename
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_SetJPEGCompression
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_SetSummaryInformation
> >>> referenced by magick/.libs/libGraphicsMagick.so
>
> ld: error: undefined reference due to --no-allow-shlib-undefined:
> FPX_WriteImageLine
> >>> referenced by magick/.libs/libGraphicsMagick.so
> cc: error: linker command failed with exit code 1 (use -v to see
> invocation)
> *** [utilities/gm] Error code 1


Fixed with patch:
-USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cpe li= btool localbase pathfix pkgconfig tar:xz
+USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cpe li= btool localbase:ldflags pathfix pkgconfig tar:xz
+FPX_LDFLAGS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 -lfpx

Tested on 13.3-p1 amd64 in poudriere and on live system.

If you agree I can commit self.

--
Best regards,
Vladimir Druzenko

Fixed in ports f57677= 209d3a6981cbb5e2bceba03c37ea2f65a8. Thanks.
However, I'd like= to remove it. I wonder if people really use fpx nowadays.
--000000000000d254030616882c3b--