Date: Mon, 12 Oct 2020 10:20:51 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Matthias Andree <mandree@freebsd.org> Cc: Christoph Moench-Tegeder <cmt@burggraben.net>, ports-committers@freebsd.org, gnome <gnome@freebsd.org> Subject: Re: svn commit: r552054 - head/x11/gnome-shell Message-ID: <20201012082051.z64bdfc76ayjdbjp@aching.in.mat.cc> In-Reply-To: <262f6c4b-30df-e5b4-99d3-393951c5cacd@FreeBSD.org> References: <202010111146.09BBkHW0018750@repo.freebsd.org> <20201011203426.GA55792@elch.exwg.net> <8359bb8b-6276-749b-9807-58488f1b65cb@FreeBSD.org> <20201011210939.GB55792@elch.exwg.net> <262f6c4b-30df-e5b4-99d3-393951c5cacd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wvywsiouohhbf6zh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Oct 12, 2020 at 01:35:29AM +0200, Matthias Andree wrote:
> Am 11.10.20 um 23:09 schrieb Christoph Moench-Tegeder:
> >=20
> > Hi,
> >=20
> > ## Matthias Andree (mandree@FreeBSD.org):
> >=20
> >> So let's take a spade and dig. There is
> >> work/gnome-shell-3.36.6/subprojects/extensions-tool/meson.build
> >>
> >> which has
> >>
> >>> bash_completion =3D dependency('bash-completion', required: get_optio=
n('bash_completion'))
> >=20
> > So it's gnome-shell which needs a dependency on bash-completion.
> > We shouldn't (must not?) rely on other ports to pull in our
> > dependencies.
> >=20
> >> So unless you are building p11-kit or gnome-control-center with
> >> non-default options,
> >=20
> > p11-kit it is (looks like the BASH option there caused me some trouble =
some
> > time ago - don't know what, but it was late and I was angry, according =
to
> > git).
> >=20
> >> Can it hurt to always include the configuration file? We're talking le=
ss
> >> than 2 kB out of 9 MB flat size.
> >=20
> > When installing gnome, that one file doesn't matter.
> > But we should get the dependencies right.
>=20
> I am not sure if it is a hard dependency. gnome-shell will work without
> bash completions for the extension manager, so it's more like a
> requisite to cheat meson for gnome-shell, i. e. BUILD_DEPENDS.
>=20
> Do we want bash-completion also as a run-time dependency? If so, it's a
> more consistent experience at the expense of two more direct requisites
> packages (bash-completion, bash).
>=20
> Any other good reasons to decide about the RUN_DEPENDS, either way?
https://www.freebsd.org/doc/en/books/porters-handbook/shell-completion.html
The executive summary being :
- don't depend on the <shell>-completion package
- always install completions
--=20
Mathieu Arnold
--wvywsiouohhbf6zh
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl+EEd5fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgKKBxAAin3wfnV5ldioAIDZiBSTF1U8UleqV4bs2sTwbOFhBtR2iqgK4UZzC5oF
PVobkuqol6L0Qer4PPoTeKVMSECvR1Cp4EkhFlZi091V2LzHkDITR/0ErRWADg2h
hs6eGvZcQPt1tM3UaqSEYUuOEFiGDgwBS261KtZis/Ll+7SeW0w9cVTJACj7070E
DntJWLGA15xjokT2QbqZZfTjDmu3J1KBrLZTHvf5lEqxHFgsnjeO7YALl/0t2M9G
htvlUQjBoXKYnNs9ohWlXH+AFjpNmvo1pffKvF0YF7zjRG91mRXDRBWSLGl35Ipj
a15AMSMtztwZe/KkHgwoJ0w3//fHTEkG+66pUTJ7ou3+lW6UyCebFb1sadqevneT
s5QdGFZMwoMiaYWnLANHR/N8k8/uxSpHPO29NnolDQFqDnGH11jP9K8Ryw4pUT/s
OzCHBMGRt3qG9ayXLJMezMRVOaREdXzOEWmlSjCtbQzwy9qt4JKisfQg24hIOomT
pnw6n2ADN3I6dTe1DFejo6tCRFKsIeOIr+0baWsnM/jh0zMbu8ypTabYRmdKe87Y
ffpyK95dT794IXsihLKJ853P+2dzIauG1VRPAWJ7FhXO84RBPbawDCChvmReb6tV
2UQpbrtbwMLbQnGa/J+keCVsNTuitBkZVFEOYhVbl/Cv55UNLg0=
=S1R6
-----END PGP SIGNATURE-----
--wvywsiouohhbf6zh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201012082051.z64bdfc76ayjdbjp>