From owner-svn-src-head@freebsd.org Tue Sep 1 16:18:25 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 409C03CDCCC; Tue, 1 Sep 2020 16:18:25 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bgsgh3rsvz3XN0; Tue, 1 Sep 2020 16:18:24 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi1-x22c.google.com with SMTP id x19so1656758oix.3; Tue, 01 Sep 2020 09:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=523Y6D+dfQeYbLTxKt6LZBIiWRE+KxKxhuJR63qLaMU=; b=Ipja0d8FzfTWps1Tvr53aS+xmFpJHdTgsABYTNkgR4k5V/9a0MgBDh9Zm5QxZFtZ/J velONlxs9n6EvQmff5/mE7LeRy79dW4YvvgXwEGxfV7HMEIYq+Ehdjc5I/aeNCFogX33 H+wyn+Vb18uN3VGkOc7opVzveDKHFbHFmwY90jaK2UTkQieAc5uQtxm1szkKVhYdRwN8 1bPH5rWRbx6G7Wctb4kFnwb18iR/vYq8vbe2RSeRmZBZxZAwCo4wLmet1ApZ0ZGUeBcl 8MvzYffosexuiBmcxuFFc9bc5OeerkaXu/kGW9wjxQ/QS+j5BbvFaT2SW52vF5qRu05A JQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=523Y6D+dfQeYbLTxKt6LZBIiWRE+KxKxhuJR63qLaMU=; b=W0RV6oa5HYGDff0db4QVS35Q0ulOf6QXI2lcLOxMZbqUJoGQrQ0q4UIi6BhURJ2siE NDJ34DX7ZkE+aXsJJypzXEK+NjVEFmRz6MiLanCXPi7GIJ0gBxUc8ieD9PoAODMtkctk Oa0aSL7lq5tv2kEON3fl83X1osM0SVLZWKxUR4hnlaaHnZqKvzuddhEB/YbTioc290Eg vy0ZrdsVRYhW6wtqH8T4XijhRaz1H5W4UF/KRRltBf2ILBtLi5xIiyMLT6Hqi6UVLkSC 0MD6d91gB95W1TTfSrHKzI6gQkPklVAvQU5uvHydt6PZUaQoCQ/75rzkGq/kB39vBtVP EKKw== X-Gm-Message-State: AOAM533tVKDwRg6zVlfWAiMSQHxm/C0yQQSb3STub90IKGS2c/+P3TBT p3hoFmBZ8ipAXrsUD9xo+l0kGobFk8wNu9uXN3xd1AQJBR8= X-Google-Smtp-Source: ABdhPJw+33bH1BonVxlnbcTx3ZrNX9Wew3ZzQEv4g/vc9XmJxPbeMR8spNP25FGyrOQeTdJLDw7zzKYOE6kpgiujELw= X-Received: by 2002:aca:b48b:: with SMTP id d133mr1671887oif.47.1598977103227; Tue, 01 Sep 2020 09:18:23 -0700 (PDT) MIME-Version: 1.0 References: <202009011611.081GBN9M025984@repo.freebsd.org> In-Reply-To: <202009011611.081GBN9M025984@repo.freebsd.org> From: Benjamin Kaduk Date: Tue, 1 Sep 2020 09:18:12 -0700 Message-ID: Subject: Re: svn commit: r365052 - head/usr.bin/script To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4Bgsgh3rsvz3XN0 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 16:18:25 -0000 On Tue, Sep 1, 2020 at 9:11 AM Warner Losh wrote: > Author: imp > Date: Tue Sep 1 16:11:23 2020 > New Revision: 365052 > URL: https://svnweb.freebsd.org/changeset/base/365052 > > Log: > Have script accept and ignore -e for Linux compat > > In the util-linux version of script, it will always exit with succes. > Except when run with -e, in which case it will have the exit value of > the child. BSD Script already uses the child's exit value for its exit > value. Some config and other helper scripts depend on being able to > specify -e. Accept it for compatibility since we'll already to the > right thing, but otherwise we ignore it. > > What kind of usage is not currently portable but becomes portable as a result of this change? I thought the BSD and GNU syntax was inherently pretty different, e.g., with '-c' for the command to run vs. implicit positional arguments, and would love to be able to retrain myself to something that works everywhere... -Ben