From owner-freebsd-virtualization@FreeBSD.ORG Fri Aug 22 09:50:07 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90241106564A for ; Fri, 22 Aug 2008 09:50:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 491E28FC32 for ; Fri, 22 Aug 2008 09:50:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 45B9141C707 for ; Fri, 22 Aug 2008 11:50:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id GLA9ZU218geJ for ; Fri, 22 Aug 2008 11:50:04 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id E1C6341C734; Fri, 22 Aug 2008 11:50:04 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 3EC0D44487F for ; Fri, 22 Aug 2008 09:47:08 +0000 (UTC) Date: Fri, 22 Aug 2008 09:47:08 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: freebsd-virtualization@freebsd.org In-Reply-To: Message-ID: <20080822094405.W66593@maildrop.int.zabbadoz.net> References: <48ABD1EF.5060307@elischer.org> <48ABD349.6030701@elischer.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: report and comment X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Aug 2008 09:50:07 -0000 On Thu, 21 Aug 2008, Mike Silbersack wrote: Hi, > On Wed, 20 Aug 2008, Julian Elischer wrote: > >>> so we have the same global variables, static, in 2 places.. >>> so one set should go in the pf vars and the other in the inet >>> vars. The first answers I think of are: >>> >>> >>> 1/ rename one set This is exactly what we did with others. See follow-up commit the next day. >>> 2/ make one of them a VV_ macro that goes elsewhere. >> >> looking at the code better... I see the entire function is about the same.. >> >> 3/ remove the duplicated code in pf and call the one in tcp_subr.c >> from both places.. > > The code originally came from tcp_subr.c, then Max copied it over to pf to > improve pf's behavior. I'm guessing that he intentionally left them seperate > so that the host part of the TCP stack wasn't interacting with the firewall > part of the system. Renaming the variables in the pf copy is probably a > better solution. I do not understand what this is actually about as pf is NOT virtualized yet. The only V_ changes in there should be, according to Marko, be in there to make the code actually compile with the rest of the V_ changes. In case we touched a shadowed file local static global variable in there I would suspect that this might be an error from the original script run and the change should be reverted. I'll have a look at this tonight. /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.