From owner-svn-src-head@FreeBSD.ORG Wed Sep 3 09:12:43 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B10F2A1; Wed, 3 Sep 2014 09:12:43 +0000 (UTC) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id B1DE71861; Wed, 3 Sep 2014 09:12:42 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id 6B51C20E7088D; Wed, 3 Sep 2014 09:12:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX, FSL_HELO_NON_FQDN_1,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no version=3.3.1 Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170]) by smtp1.multiplay.co.uk (Postfix) with ESMTP id C504F20E70886; Wed, 3 Sep 2014 09:12:37 +0000 (UTC) Message-ID: <7DF8E1BCE4E648888B9AA8BABB1A5991@multiplay.co.uk> From: "Steven Hartland" To: "Andriy Gapon" References: <201408281950.s7SJo90I047213@svn.freebsd.org> <39211177.i8nn9sHiCx@overcee.wemm.org> <201409021201.15967.jhb@freebsd.org> <5405F1F3.1@FreeBSD.org> <8AA1D02BB967468DA07731149E95390D@multiplay.co.uk> <5406D972.8010305@FreeBSD.org> Subject: Re: svn commit: r270759 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs vm Date: Wed, 3 Sep 2014 10:12:39 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-15"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: src-committers@FreeBSD.org, John Baldwin , Peter Wemm , Alan Cox , svn-src-all@FreeBSD.org, Dmitry Morozovsky , "Matthew D. Fuller" , svn-src-head@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 09:12:43 -0000 ----- Original Message ----- From: "Andriy Gapon" > on 02/09/2014 20:43 Steven Hartland said the following: >> ----- Original Message ----- From: "Andriy Gapon" >>> And the newly added kmem_foo() functions probably do not belong in >>> cddl/compat/opensolaris as Solaris / illumos does not have those functions. >> >> They could be moved but their current location keeps all the kmem >> related functions neatly in one place. Spreading them around IMO >> would just make things hard to find. > > BTW, here is some of my old WIP that completely removed the pre-existing kmem_* > functions and made the related code much closer to that in illumos. > Unfortunately, I will now have hard time merging my changes with your change. > > https://github.com/avg-I/freebsd/compare/wip/hc/kmem_size-memguard-fix > (esp.commits e0cf2f7 and becf087) Looking good, I'm all for eliminating the differences between the two code bases as that will make things easier to maintain in the future, so something we should definitely try to get in for 11. Regards Steve