From owner-freebsd-hackers@FreeBSD.ORG  Mon Sep 27 11:20:39 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 222F3106564A
	for <freebsd-hackers@freebsd.org>; Mon, 27 Sep 2010 11:20:39 +0000 (UTC)
	(envelope-from ubique@peterhost.ru)
Received: from fb0.z8.ru (fb0.z8.ru [80.93.58.95])
	by mx1.freebsd.org (Postfix) with ESMTP id D13828FC0C
	for <freebsd-hackers@freebsd.org>; Mon, 27 Sep 2010 11:20:38 +0000 (UTC)
Received: from smtp.z8.ru ([80.93.57.71])
	by fb0.z8.ru with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <ubique@peterhost.ru>) id 1P0BWX-000OjL-Ot
	for freebsd-hackers@freebsd.org; Mon, 27 Sep 2010 15:05:33 +0400
Received: from [212.116.101.94] (helo=amnesiac.pht)
	by smtp.z8.ru with esmtpa (Exim 4.71 (FreeBSD))
	(envelope-from <ubique@peterhost.ru>) id 1P0BWQ-000F2j-SC
	for freebsd-hackers@freebsd.org; Mon, 27 Sep 2010 15:05:27 +0400
Date: Mon, 27 Sep 2010 15:04:21 +0400
From: Dmitry Banshchikov <ubique@peterhost.ru>
To: freebsd-hackers@freebsd.org
Message-ID: <20100927150421.260874f0@amnesiac.pht>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.6; amd64-portbld-freebsd8.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 212.116.101.94
X-SA-Exim-Mail-From: ubique@peterhost.ru
X-SA-Exim-Scanned: No (on smtp.z8.ru); SAEximRunCond expanded to false
Subject: little mistake in rc.subr?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Sep 2010 11:20:39 -0000

Hello,

In /etc/rc.subr, at line 231, there is:

if [ ! -f $_pidfile ]; then
debug "pid file ($_pidfile): not readable."
    return
fi

Is check "[ ! -r $_pidfile ]" more correct?


-- 

Dmitry Banshchikov