From owner-cvs-all Thu Sep 28 13:16: 6 2000 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 3E35437B422; Thu, 28 Sep 2000 13:15:59 -0700 (PDT) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id WAA69689; Thu, 28 Sep 2000 22:15:57 +0200 (CEST) (envelope-from des@ofug.org) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: cvs-committers@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/savecore savecore.c References: <200009282009.NAA38027@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 28 Sep 2000 22:15:56 +0200 In-Reply-To: Dag-Erling Smorgrav's message of "Thu, 28 Sep 2000 13:09:37 -0700 (PDT)" Message-ID: Lines: 19 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Dag-Erling Smorgrav writes: > Remove superfluous code: > [...] (this is almost, but not quite, the patch I posted to -developers) Two things of interest regarding devname(): 1) the current implementation of devname() never returns NULL, so find_dev() in savecore.c is overly defensive. 2) the devname(3) man page is out of sync with the code, since devname() now never returns NULL, and the fallback is not "??" but "#X:maj:min" where X is either "C" or "B" depending on the device type. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message