From owner-cvs-all  Fri Feb  6 15:00:54 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id PAA17714
          for cvs-all-outgoing; Fri, 6 Feb 1998 15:00:54 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from lsd.relcom.eu.net (ache@lsd.relcom.eu.net [193.124.23.23])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA17707;
          Fri, 6 Feb 1998 15:00:48 -0800 (PST)
          (envelope-from ache@lsd.relcom.eu.net)
Received: (from ache@localhost)
	by lsd.relcom.eu.net (8.8.8/8.8.8) id CAA24897;
	Sat, 7 Feb 1998 02:00:36 +0300 (MSK)
	(envelope-from ache)
Message-ID: <19980207020036.28713@nagual.pp.ru>
Date: Sat, 7 Feb 1998 02:00:36 +0300
From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
To: Bruce Evans <bde@zeta.org.au>, cracauer@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
        cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/bin/sh jobs.c
Mail-Followup-To: Bruce Evans <bde@zeta.org.au>, cracauer@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG,
	cvs-committers@FreeBSD.ORG
References: <199802061928.GAA07506@godzilla.zeta.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.89.1i
In-Reply-To: <199802061928.GAA07506@godzilla.zeta.org.au>; from bde@zeta.org.au on Sat, Feb 07, 1998 at 06:28:44AM +1100
Organization: Biomechanoid
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe cvs-all"

On Sat, Feb 07, 1998 at 06:28:44AM +1100, Bruce Evans wrote:
> >  Modified files:
> >    bin/sh               jobs.c 
> >  Log:
> >  Fix handling of SIGINT/SIGQUIT for foreground subprocesses. Most
> >  urgent need is when you run sh around a program that intentionally
> >  uses SIGQUIT/SIGINT for asynchronous events, i.e. $EDITOR started from
> >  system(2), like many mailers do. This fixes PR bin/1206 and possibly
> >  bin/4241.
> >  
> >  The solution committed has been tested for a large number of possible
> >  cases (see recent discussion on cvs-committers). I completed a make
> >  world, made sure 'make world' is interruptable and used the changed
> >  /bin/sh as a login shell all day, including job control and using
> >  SIGQUIT-catching programs (to write this message :-).
> >  
> >  PR:		bin/1206
> >  Reviewed by:	discussion on cvs-commiters
> 
> I thought we were still discussing it.  I didn't like it before, and
> like it less now.  The committed version has the following bugs:
> 
> 1) SIGINT/SIGQUIT are not restored after fork failure.
> 2) SIGINT/SIGQUIT are always reset to SIG_DFL in the child.  This is
>    wrong if these signals are ignored on entry to the shell.

I agree with Bruce. I can confirm that discussion still not finished: my
complaint was equal to 1) in his list and I see no answer from you too. 
Please back out your change and resolve all issues first. Personaly I like
Bruce's variant more. 

-- 
Andrey A. Chernov
<ache@nietzsche.net>
http://www.nagual.pp.ru/~ache/