From owner-freebsd-net@FreeBSD.ORG Wed Apr 15 12:53:36 2015 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C8163513; Wed, 15 Apr 2015 12:53:36 +0000 (UTC) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 633EAA1E; Wed, 15 Apr 2015 12:53:36 +0000 (UTC) Received: by lbbqq2 with SMTP id qq2so33042044lbb.3; Wed, 15 Apr 2015 05:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tdlLI+z5VOtm4gZnzGi8/RPO72O1fvHyzaiXhQ7gbmo=; b=CntbsQfyrNeQSumOB/YcYlCqk34sokd5zLaJ27vODTfl3UHk5gU3+aBhsOVTinlTZW EyeZn3wlIZNY1Vitg0UnpEAll42bYgT6fnrEH5OM2Bf4Yp7xB9L3z6skIR4gcAQATAax LFMikAK/x9007qufZNTFkC2F2bJ4bbL0Rc4K/0GOOHrF8Vgts3kkW1Dusy7J3vNLfU3q I3hhDknZFKndBCRbOuj5KITR67m8gtUWCP+3QH9YNNDau9Dof7vZWTZOFAJNdJ/7Lw6L u/4Y3b4xxvhRM0gjXGMYnzJNW6X858L9/SOKd1XupFqhzBoMuo4VL+DJjL5++oA5DxMs agJg== MIME-Version: 1.0 X-Received: by 10.152.7.209 with SMTP id l17mr23952264laa.100.1429102414462; Wed, 15 Apr 2015 05:53:34 -0700 (PDT) Sender: rizzo.unipi@gmail.com Received: by 10.114.180.4 with HTTP; Wed, 15 Apr 2015 05:53:34 -0700 (PDT) In-Reply-To: <20150415122627.GZ883@glebius.int.ru> References: <20150414135346.GU883@FreeBSD.org> <20150415073823.GA94402@onelab2.iet.unipi.it> <20150415122627.GZ883@glebius.int.ru> Date: Wed, 15 Apr 2015 14:53:34 +0200 X-Google-Sender-Auth: 32hYwqM-KH6QCbYVEEV3HDmZSlo Message-ID: Subject: Re: moving ALTQ out of contrib From: Luigi Rizzo To: Gleb Smirnoff Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 12:53:37 -0000 On Wed, Apr 15, 2015 at 2:26 PM, Gleb Smirnoff wrote: > On Wed, Apr 15, 2015 at 09:38:23AM +0200, Luigi Rizzo wrote: > L> > With the new ifnet KPI, that is now being developed in projects/ifnet, > L> > the ALTQ will need some tweaking. It is discontinued by initial author > L> > for a decade now, and it has already experienced direct commits in > L> > our tree. Thus, I see no good reasons to continue keeping it in contrib. > L> > In NetBSD they have it in sys/altq. > L> > > L> > I'd prefer to move it to sys/net/altq. > L> > > L> > Any objections or better ideas? > L> > L> my first question is what is the expected residual lifetime of altq ? > > If I get it working properly in projects/ifnet, I see no reasons to > remove it. It is going to be a plugin into network stack and will no > longer require editing drivers. It will run on drivers that aren't > supported by ALTQ now. However in the latter case the ALTQ will sit > on top of interface own queue, and will start to work only when > interface's own queue overflows. But if we later add a new interface > method to modify length of own queue at runtime, this issue will > go away. > > L> If it is destined to be removed soon (and probably that is not > L> unlikely given its unmaintained state, the absence of multiqueue > L> support etc.) maybe we could live for the next > L> couple of years just leaving it where it is now and avoid the > L> repo churn. > L> > L> If we really plan to relocate the code, I guess the options are > L> > L> sys/altq as in netbsd > L> > L> sys/netaltq this would be an alternative location to > L> the above one, justified by the fact that > L> we have already a bunch of net* subdirs > L> > L> sys/net/altq as you propose, i guess to stay close to > L> the rest of the ifnet code (and perhaps > L> as a first step in cleaning up sys/net > L> by putting stuff in various subdirs) > L> > L> In any case my preference would really be to leave it where it is. > > I don't like to keep in contrib a code maintained and edited by the > project. Especially I don't like tautological path of contrib/altq/altq. > I don't like extra glue in Makefiles, especially modyfing CFLAGS for the > whole kernel build. > > If it is a regular piece of kernel code, let it be like the rest of > kernel code. ok thanks for the clarification. Then if you do sys/net/altq/ do you also plan to split the current content of sys/net/ into separate subdirectories ? We currently have quite a few separate things in sys/net/, such as - various bpf files - generic ifnet support (including raw sockets) - various libraries (compression and hash functions) - routing code - bridging code - a ton of special ifnets, (tun, tap, epair, gif, ....) - bridging code that could benefit from a bit of partitioning cheers luigi