From owner-freebsd-hackers@FreeBSD.ORG  Wed Oct 27 13:27:57 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AF48D106564A
	for <freebsd-hackers@freebsd.org>; Wed, 27 Oct 2010 13:27:57 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 80A688FC13
	for <freebsd-hackers@freebsd.org>; Wed, 27 Oct 2010 13:27:57 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 3231746B2E;
	Wed, 27 Oct 2010 09:27:57 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id DB37E8A009;
	Wed, 27 Oct 2010 09:27:55 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Wed, 27 Oct 2010 09:12:47 -0400
User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; )
References: <1288160610.4280.18.camel@apollon>
	<AANLkTimCN+Y4OsJRNvdmXidLu8XPHz5RydAhe0phvgnH@mail.gmail.com>
In-Reply-To: <AANLkTimCN+Y4OsJRNvdmXidLu8XPHz5RydAhe0phvgnH@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201010270912.47076.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Wed, 27 Oct 2010 09:27:55 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx
Cc: Lars Hartmann <lars@chaotika.org>, Sergey Kandaurov <pluknet@gmail.com>
Subject: Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2010 13:27:57 -0000

On Wednesday, October 27, 2010 7:33:13 am Sergey Kandaurov wrote:
> On 27 October 2010 10:23, Lars Hartmann <lars@chaotika.org> wrote:
> > The vgonel function isnt declarated in any header, the vgonel prototype
> > in vgone(9) isnt correct - found by Ben Kaduk <kaduk@mit.edu>
> 
> Hi.
> 
> I'm afraid it's just an overlooked man page after many VFS changes in 5.x.
> As vgonel() is a static (i.e. private and not visible from outside) function
> IMO it should be removed from vgone(9) man page.

Agreed.  It certainly should not be added to vnode.h.  I'm curious how the 
reporter is getting a warning since there is a static prototype for vgonel() 
in vfs_subr.c.

-- 
John Baldwin