From nobody Tue Mar 4 04:25:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z6Mzk2zjZz5pSBc; Tue, 04 Mar 2025 04:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z6Mzk2Q5tz46FR; Tue, 04 Mar 2025 04:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741062322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kbpZZNb804iiUdsDXYOyEnUy7rAVLn1RPMUMsWF8dRI=; b=DIvmu2W+s6G2/RjIi3Svzy/adP6cYpNJbqDtvRKBM36TZ8O/7XQuo4GEBidE3WHcxVMNFT 1M+BDrFWgsHY6QR5Ykv3b42Uq2bm/oh4e28X6wqq2K3tHSrfaVrUBl3W6CSMlVJA97SUxQ cjfM57gFSX2AB15cqhimijs62n9FcfX2vnMlzposXNHuMOmy7borkF9Bq6nIEn5D5rJCkL 4a5BQDEPx8dUkmSWUMpP3lYGjSKvbUlcU917sVAhH/4PBkqDXYlWb/xlc+JxmWRQV7ez9b FQFFNc4KCEECF7+aSVKG5G/Hq/lr3rXrSbtAxI+OA6MlMpOHy9mvbDpISZzmFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741062322; a=rsa-sha256; cv=none; b=a/agzwG4tqasQtTNmZLWRr8bH2+dTsmyDUUc7JSDFHkwyHujxWhwexixpvgpGYqoN1/DAk lHV3/eT+5T+7qHtETLtkwhqT3H+tSBR4KeMkh4/Rv3733ZrYiZ6Pk5Wwr4MpflG4NVMv/B yiaN2jVEy1PJc71nekl9LgpvGJZCzOOJzfiQ7t+Y4VveCzBOSXd5tmmWu5ljX+fwjyWFuv XCFFSM6ugz5SwZvdhjWtWb+XbXlaKaH0ngOLI3ziXzLWKD6ETSAapU91Ggv3+jEP75RK8o FiaKP0T0U/KmJ1Lw3Kk8spewOwehhH2Yzp2uCuN+thfjnQEgxGhO160S8sqhzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741062322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kbpZZNb804iiUdsDXYOyEnUy7rAVLn1RPMUMsWF8dRI=; b=aWyxu+xoVp65OUXjheLbxbZulwDM7ig7cp9Up8ak1tUIzw40CEQGcf21vME36wTupYDIUF k3eoBYic96cqwa3IzcwRQ1zwM+3moT+egstkh9poC/vilqAvi5XWQHCRPB31pEzKgcQrR0 OLmYiFTmdkRlw4Ymne9DrB3mHYKKU1dAYn92HfghLEFsKBKdAeBzHb8PhAx020tcLz1q/E 2GZbdmc3GemO5c4vlumm1rMZMSZsecH7gzF1VNLoRzNv3XTI5EwYd/v1sgVBIRWOeQrZq6 WhRnbOb0w5gPfH9R5uBi4p90dymCiLUxOdiggIZvLwfpeuRtq2v/7BVaveIEUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z6Mzk1nYDz1H95; Tue, 04 Mar 2025 04:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5244PMh0072927; Tue, 4 Mar 2025 04:25:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5244PMkO072924; Tue, 4 Mar 2025 04:25:22 GMT (envelope-from git) Date: Tue, 4 Mar 2025 04:25:22 GMT Message-Id: <202503040425.5244PMkO072924@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: cb991a228179 - main - amd64 csu: microoptimize startup List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cb991a228179639cc0568fdd5d4b4b07b6f47b5a Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=cb991a228179639cc0568fdd5d4b4b07b6f47b5a commit cb991a228179639cc0568fdd5d4b4b07b6f47b5a Author: Konstantin Belousov AuthorDate: 2025-03-02 23:54:24 +0000 Commit: Konstantin Belousov CommitDate: 2025-03-04 04:24:59 +0000 amd64 csu: microoptimize startup Reorder operations to reduce moving the values among registers. Use the LEA instruction to combine arithmetic with the moves. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D49206 --- lib/csu/amd64/crt1_s.S | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/csu/amd64/crt1_s.S b/lib/csu/amd64/crt1_s.S index f7ea076d94f1..3ceea9289330 100644 --- a/lib/csu/amd64/crt1_s.S +++ b/lib/csu/amd64/crt1_s.S @@ -49,15 +49,12 @@ _start: #ifdef GCRT subq $16, %rsp #endif - movq %rsi, %rcx - movq %rdi, %rsi /* argv = ap */ - addq $8, %rsi /* argv += 1 */ - movq %rdi, %rdx /* env = ap */ - addq $16, %rdx /* env += 2 */ - movslq (%rdi), %rax - movl %eax, %edi /* argc = *(long *)(void *)ap */ - shlq $3, %rax - addq %rax, %rdx /* env += argc */ + movq %rsi, %rcx /* cleanup */ + movslq (%rdi), %rax /* long *ap; tmpargc = *ap */ + leaq 0x8(%rdi), %rsi /* argv = ap + 1 */ + leaq 0x10(%rdi, %rax, 8), %rdx /* env = ap + 2 + tmpargc */ + movl %eax, %edi /* argc = tmpargc */ + #ifdef PIC /* * XXX. %rip relative addressing is not intended for use in the