From owner-cvs-all@FreeBSD.ORG Tue Mar 1 01:35:43 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D6E11065670; Tue, 1 Mar 2011 01:35:43 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id 535378FC16; Tue, 1 Mar 2011 01:35:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id 044331711F; Mon, 28 Feb 2011 20:35:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:reply-to:message-id :subject:subject:from:from:date:date:received:received; s=aegis; t=1298943330; bh=Wh1njheJiyRKGE3V5NFueBT4pyunnbrzmQhONH/Ix7g=; b= loju81g1rqRPiD9vvGojwDd0YTr/ovLkwG7H12w9SWcmz0xwM+VNwe7I/n3YpFr0 ioL1YyA5bonLA4DznQgKU8zHB+NJ5SVZ13FAoKdyhrXwXLg5Lu+Vc0RuWkSl0k5k sVhtE9onCD8p+Ek/5NhQ+8mu59WlgwXgKZtHv0oKMV8= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id zfTpIfdDIYSc; Mon, 28 Feb 2011 20:35:30 -0500 (EST) Received: from magic.hamla.org (cpe-69-201-179-80.nyc.res.rr.com [69.201.179.80]) by spartan.hamla.org (Postfix) with ESMTPSA id 1820917117; Mon, 28 Feb 2011 20:35:28 -0500 (EST) Date: Mon, 28 Feb 2011 20:35:26 -0500 From: Sahil Tandon To: araujo@FreeBSD.org Message-ID: <20110301013525.GA44112@magic.hamla.org> References: <201102271441.p1REfMrT016669@repoman.freebsd.org> <20110227193203.GA38353@magic.hamla.org> <4D6AB7BD.2060203@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: cvs-ports@freebsd.org, Doug Barton , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/trafshow Makefile distinfo X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sahil Tandon List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2011 01:35:43 -0000 On Mon, 2011-02-28 at 01:18:32 -0300, Marcelo Araujo wrote: > > On 02/27/2011 11:32, Sahil Tandon wrote: > > > > If the IPv6 option is off by default (and thus, does not affect the > > default package), why do you bump PORTREVISION? I just want to > > understand for my own edification when dealing with similar > > situations. > > Well, I've used the latest paragraph that discribe when we should bump > PORTREVISION. > > """A rule of thumb is to ask yourself whether a change committed to a > port is something which someone, somewhere, would benefit from having > (either because of an enhancement, fix, or by virtue that the new > package will actually work for them). If yes, the PORTREVISION should > be bumped so that automated tools (e.g. pkg_version) will highlight > the fact that a new package is available.""" > > As the IPv6 option can be a good enhancement for trafshow, I decided > to BUMP PORTREVISION. I believe in this case it is OK. If not, please > someone else correct me. Thanks for your response. I do not mean to nag, but I am still not 100% clear. The quote above ends with "highlight the fact that a new package is available". Because IPV6 is off by default, no new package is actually available -- the default package remains functionally unchanged. I agree that IPV6 is a good enhancement, but if that itself (regardless of whether it changes the package) warrants a PORTREVISION bump, perhaps we can clarify the language in the Porter's Handbook. If the language is clear as-is, and it is just my failure to correctly interpret it, then let me know. > I'm gonna checking how the other ports dealing with IPv6 support, then > I'm gonna check if it stay like now or put it by default ON. If there is a new option that is enabled by default, then I think we all agree to increment PORTREVISION. -- Sahil Tandon