From owner-freebsd-current@freebsd.org Fri Sep 29 17:18:14 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D28DDE310C2 for ; Fri, 29 Sep 2017 17:18:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A35476E7A9 for ; Fri, 29 Sep 2017 17:18:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22a.google.com with SMTP id i197so378081ioe.9 for ; Fri, 29 Sep 2017 10:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=vBE0vCY9XcLj7D+cfyzi8/apOavMKxXQM2db/k+NUf8=; b=m2vJHRJ9MdkG/1uF8UcR0kCmr69EvvMo0wJuudJrSTrfCUg2wtA9l4zm2VLd+wXYTS 9/hBXls7Chl4oTxPL1vR3DqTZKM5yFAYPB+YOJo83D4lRMWKooxrELAytuXjIWcWpQJN 3zPWp9XQBQrNLKfN/XhscSUdb7oHc7k1NL7UQ/bMs+NmF5ZYG1vdeDA56AzX5cs4OV5T rV1v5sC5vs9/d0GXOZv7Og7pi0HRIn95+E9+dpkyPcZZ28l/eNGkJNIIDvaEOL5cN2WL cdNtPCe8JLiC72CQxvpGTqIK31mz4ugFSGD6/4nZHItL90e2ok+uGtNRnZtztAdjnAri O+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=vBE0vCY9XcLj7D+cfyzi8/apOavMKxXQM2db/k+NUf8=; b=BVbiOpRiXvIW2YZklHQw8akc4mJ6prG2uCad1IrLgRtgn/tMWHFjlOuy9j1/2uxa5x RTGLjABCyzac0bju7AThL3gg3chUP/TPPfHqmfrub73PGK6a986xT9QJdOH0QrnOaUIC ndkKEqBQNPN7CAkyl9nZdySXJSRmZMMAJxpwpfbZZwW7LcZR4jPbPXTxkB09ofPTf924 BPoCgJu6FFdMR5Xg+4DzcNIFHEBW9Ck6GEfdZ2DDWY8O+0kQXC7mufkGUishRB1ix9mD R87BZOkF5Wk0bTxs4PcawXXG70zZls1mKfQ/9ju+pAYl2DNfezSZX/av08T2yH/2diXZ 8Xig== X-Gm-Message-State: AMCzsaWNNv2a5+mVm562/fxyzu56nAS3CH8B2zbACOAxx2ZKX5I5mgI7 nU+CMQTSKwBsJZg0l4Q+uITC4rkOg7PeeBlm9wQDqQ== X-Google-Smtp-Source: AOwi7QC35QV2m3yWKKJzIPYbyHrxhs4q8iXM9gKXw72SVwL8tg6gLpH9bvAVkzfiAb81P1P9UflzXwqfsTOrR98/ptk= X-Received: by 10.107.68.6 with SMTP id r6mr13676690ioa.282.1506705493915; Fri, 29 Sep 2017 10:18:13 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.2.194 with HTTP; Fri, 29 Sep 2017 10:18:13 -0700 (PDT) X-Originating-IP: [96.88.77.243] In-Reply-To: References: <201709290109.v8T19oMO028898@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Fri, 29 Sep 2017 11:18:13 -0600 X-Google-Sender-Auth: HHRgV3ZbGuWPIzSpsGFJsIf2hQE Message-ID: Subject: Re: How do GEOM_PART_* options configure geom_part_* modules?? To: Kevin Oberman Cc: "Rodney W. Grimes" , Nick Hibma , FreeBSD Current Mailing List Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 17:18:14 -0000 On Thu, Sep 28, 2017 at 11:54 PM, Kevin Oberman wrote: > On Thu, Sep 28, 2017 at 6:09 PM, Rodney W. Grimes < > freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > >> > On Thu, Sep 28, 2017 at 11:12 AM, Kevin Oberman >> wrote: >> > >> > > On Thu, Sep 28, 2017 at 9:13 AM, Warner Losh wrote: >> > > >> > >> On Thu, Sep 28, 2017 at 10:00 AM, Nick Hibma > > >> > >> wrote: >> > >> >> > >> > I created a new kernel config file from scratch, wondered what the >> > >> > GEOM_PART_MBR option and friends were doing, search for them, >> didn't >> > >> find >> > >> > them in the tree, and deleted them from my config. But... de >> resulting >> > >> disk >> > >> > image didn't boot, because of the fact that it didn't recognise >> the MBR >> > >> > partitions (it only had a single diskid entry on the mount-root >> prompt). >> > >> > >> > >> > Can anyone explain to me how these kernel options work, as in: >> they are >> > >> > defined in kernel configs and as a consequence in opt_geom.h, but >> how >> > >> are >> > >> > they actually used to select which geom_part_* modules/kernel >> parts to >> > >> > build? I thought these options were translated to stuff that cpp >> would >> > >> use, >> > >> > but there are not uses of for example GEOM_PART_MBR anywhere for >> > >> example! >> > >> > >> > >> > >> > >> > The module always build them because they are listed in the >> module's >> > >> > Makefile. >> > >> > >> > >> > The kernel only sometimes does. Here's the key lines from >> conf/files: >> > >> > files:geom/geom_bsd_enc.c optional geom_bsd | geom_part_bsd >> > >> > files:geom/part/g_part_apm.c optional geom_part_apm >> > >> > files:geom/part/g_part_bsd.c optional geom_part_bsd >> > >> > files:geom/part/g_part_bsd64.c optional geom_part_bsd64 >> > >> > files:geom/part/g_part_ebr.c optional geom_part_ebr >> > >> > files:geom/part/g_part_gpt.c optional geom_part_gpt >> > >> > files:geom/part/g_part_ldm.c optional geom_part_ldm >> > >> > files:geom/part/g_part_mbr.c optional geom_part_mbr >> > >> > files:geom/part/g_part_vtoc8.c optional geom_part_vtoc8 >> > >> > >> > >> > which turn on/off which files get included. config "helpfully" >> converts >> > >> the >> > >> > upper case options to lower case for this. >> > >> > >> > >> > Warner >> > >> > >> > >> > >> > >> > *slaps forehead* Goose chase! >> > >> > >> > >> > I actually knew that... and, at the time, thought it was weird >> > >> behaviour. >> > >> > ''grep" would not have failed me if those options would be >> uppercase >> > >> there >> > >> > ... >> > >> > >> > >> >> > >> I've been nibbled to death by these geese often enough to have a >> PTSD-like >> > >> reaction when someone mentions it and habitually add -i to my >> greps... >> > >> >> > >> Warner >> > > >> > > >> > > This horrid POLA violation seems to have been in FreeBSD configuration >> > > since at least 3.0 and probably goes back to the creation of the >> > > configuration process. >> > > >> > > Any idea why such a horrible POLA was ever introduced? Seems like an >> > > obviously bad idea in an OS that is ALMOST always case sensitive. >> > > >> > >> > It's received code from the old 4.3 BSD config program (or maybe the >> net-2 >> > config program). >> >> We had best not have any code direct from 4.3 or net-2, it should be from >> 4.4BSDLite, any code prior to that is subject of the lawsuit. >> >> >> -- >> Rod Grimes >> rgrimes@freebsd.org >> > > I believe any code in 4.3 BSD that was developed by CSRG was not subject > of the suit. Copyright on that code by the Regents of UC, not AT&T. (So was > any code I wrote.) Many utilities were from v8 or descended from AT&T code, > but a great deal was not. It was what UC was getting paid for. > Yea, the suit quickly devolved into the short list of files... v8 was from BSD that was reimported. That's clear from the TUHS archive. v8 is a big break from v7... Warner