From owner-freebsd-scsi@FreeBSD.ORG  Tue Oct 31 03:39:36 2006
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
X-Original-To: freebsd-scsi@freebsd.org
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3DEED16A40F
	for <freebsd-scsi@freebsd.org>; Tue, 31 Oct 2006 03:39:36 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (ns1.feral.com [192.67.166.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1828A43D64
	for <freebsd-scsi@freebsd.org>; Tue, 31 Oct 2006 03:39:31 +0000 (GMT)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (localhost [127.0.0.1])
	by ns1.feral.com (8.13.8/8.13.8) with ESMTP id k9V3dV8X019261
	for <freebsd-scsi@freebsd.org>; Mon, 30 Oct 2006 19:39:31 -0800 (PST)
	(envelope-from mjacob@freebsd.org)
Received: from localhost (mjacob@localhost)
	by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id k9V3dVYL019258
	for <freebsd-scsi@freebsd.org>; Mon, 30 Oct 2006 19:39:31 -0800 (PST)
	(envelope-from mjacob@freebsd.org)
X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs
Date: Mon, 30 Oct 2006 19:39:31 -0800 (PST)
From: mjacob@freebsd.org
X-X-Sender: mjacob@ns1.feral.com
To: freebsd-scsi@freebsd.org
In-Reply-To: <7579f7fb0610300801x4650cb3fgb93f662fbf7b4213@mail.gmail.com>
Message-ID: <20061030193803.D19253@ns1.feral.com>
References: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com> 
	<7579f7fb0610282210p59de2123g379f0d4069bd1e42@mail.gmail.com> 
	<45443C7F.5040508@samsco.org>
	<7579f7fb0610300801x4650cb3fgb93f662fbf7b4213@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: Fwd: CAM_NEW_TRAN- kernel changes ready for review
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mjacob@freebsd.org
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Oct 2006 03:39:36 -0000


Scott Long wrote:
> 3) For atapi-cam, I think that the cts->protocol should still be
> PROTO_SCSI, not PROTO_ATA.  Having cpi->transport by XPORT_SPI also
> seems wrong, as IDE is fairly different from SPI, and I'd like at some
> point to have a real IDE/SATA transport that understands the
> differences.

Fixed in the patches, plus some of the style(9) nits.

I intend to commit tonite.

-matt