From owner-cvs-all Tue Dec 5 15:22: 5 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 5 15:22:01 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id D5E6337B400; Tue, 5 Dec 2000 15:22:00 -0800 (PST) Received: from laptop.baldwin.cx (root@dhcp246.osd.bsdi.com [204.216.28.246]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eB5NLY758575; Tue, 5 Dec 2000 15:21:34 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20001205150745.D46252@dragon.nuxi.com> Date: Tue, 05 Dec 2000 15:22:15 -0800 (PST) From: John Baldwin To: "David O'Brien" Subject: Re: cvs commit: src/sys/vm phys_pager.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alfred Perlstein Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 05-Dec-00 David O'Brien wrote: > On Tue, Dec 05, 2000 at 02:59:08PM -0800, Alfred Perlstein wrote: >> > Didn't this *same* discussion come up just last week... perhaps you are >> > a little too 'D'elete key happy. >> >> 1) I tested it under -stable before -current. >> 2) I needed it working. >> 3) It was a bugfix and needed. >> 4) It defaults to off in all systems. >> 5) It was reviewed. >> 6) I have extreme doubts that anyone could have been using it reliably >> before my fix. >> 7) It's been broken for many months, I finally spent all night tracking >> it down and the Maintainer (peter) didn't seem interested in chasing >> down the problem when I told him about it months ago. > > > Which of the 7 points above is allows an immediate MFC by our general MFC > rules? An excerpt from the Committer's Guide, Rule 5: "...unless the -STABLE fix is critical, time sensitive or so obvious as to make further testing unnecessary (spelling fixes to manpages, obvious bug/typo fixes, etc.)" If you had looked at a) the patch, and b) the thread on -hackers, you would have seen that this is an obvious bug/typo, and for people who use phy_backed_shm a critical fix since the functionality was badly broken. This option is not on by default and is most likely not being used by anyone running -current right now as it is a very special case. I'll also note the very end of rule 5: "In other words, apply common sense." -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message