From nobody Tue Sep 16 13:38:30 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cR2zV6FVjz67GNy; Tue, 16 Sep 2025 13:38:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cR2zV5Cbzz3SDm; Tue, 16 Sep 2025 13:38:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758029910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4wUXLQT8sLVCJoEH2uikaMl0Oj+B9U4qROFfUE+Tic=; b=Hy8VlFb/Z3DV3Wmb9rcFDdEml3sHEs82jEtnl2jKNwFqt5kZOtNdT25kZfHjOlAkGCaLYx iUL22S4f4n3yvZ3+N+JC+9fXiUZl1pBu1VHXsz14yIm2MZjxWEq7Yk6vFKOMSJaL+wp6Jk XJNZvhXI4db/2Hub39rA7iUfZGbDcERe/lDdRmS4IjHeL2DXtKDgpDhgzXMkzrveop3P5g w1okqnEG0mXX4GtpjZLfqy24kJ9uRY523MiP7uuzavS5z4jfGsTgvq+7FYa4wlphZWwJer nNYYs793oYnb8WOP2YRtCiBW62XEJr7iV1fO59hbQQdf5iMKGVRKojgnVkt9WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758029910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4wUXLQT8sLVCJoEH2uikaMl0Oj+B9U4qROFfUE+Tic=; b=WA55T9dxEzCidFMYzGqbwHl8pQUfN3REOMMtcRoGLToUvGaKO+gMYVf4idaQIusmyrohdc 7eNe36PaCBK1Q308TcE9OBi0wGn6JBoxNkg2clEDRTkmfuWUPzMJlue71OYUrAB68kpV+L c3IgVv8dL+AaxDau4f3Ix7sSJm+6vpaFd0BePlXweTRYqFdvvhY9XTUn01qOcHvPRKGdQF RopezqAnn5FxAZGgFhAAWjLHVPsY36R5O9tgU2X+B1GNmGSzdCn0FLtMI621JiMhBlQPDr 98dpuzL82EkvhiqjnAj/4saRpGibToBnbCIMRWMcjZgKBBtP5265hEvU8QB9gA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758029910; a=rsa-sha256; cv=none; b=SM4yPOPj442OdQ1EVpJUnm16KtUPRGR/1eRChvGKmZXozwNc9mvbZsjNTEH1DDYzNCSbdp gJc09eu9Q2nRjS1EWdZvULd1R/GSTMqDdDG0Az7ZwdTRj+m+Yku+d8Lp+k5ABv7sNqF6jg 1CPmQ1XX+SrfL/LXjcgZEMWZXcdQEYThwZ0ubc8SG4jHaMaWK7aXL0/G+dz5v3/UCrRulS T4jqxoy4hTrYAKbexTqRYIipqAH+eQsURx4PENFUlDNFaaNI0HVBXlPFQH/y9M+gwOz+5r DwVM8/oiNxjlS3rrxJaWFumLJYagoPiX79US/fn+TsWvTognZdJqDQe4Qq4n9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cR2zV4VQJzjYR; Tue, 16 Sep 2025 13:38:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58GDcUAL026132; Tue, 16 Sep 2025 13:38:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58GDcUo4026129; Tue, 16 Sep 2025 13:38:30 GMT (envelope-from git) Date: Tue, 16 Sep 2025 13:38:30 GMT Message-Id: <202509161338.58GDcUo4026129@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 9b8224b950fb - main - cp: Drop test helper List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9b8224b950fb74c8674d257a5a4795baa759c35b Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=9b8224b950fb74c8674d257a5a4795baa759c35b commit 9b8224b950fb74c8674d257a5a4795baa759c35b Author: Dag-Erling Smørgrav AuthorDate: 2025-09-16 13:38:03 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-09-16 13:38:26 +0000 cp: Drop test helper Now that stat(1) can report whether a file is sparse, we no longer need a helper program for our tests. Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52482 --- ObsoleteFiles.inc | 3 ++ bin/cp/tests/Makefile | 2 -- bin/cp/tests/cp_test.sh | 2 +- bin/cp/tests/sparse.c | 73 ------------------------------------------------- 4 files changed, 4 insertions(+), 76 deletions(-) diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index 02a727d631bd..ae83035b5de5 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -51,6 +51,9 @@ # xargs -n1 | sort | uniq -d; # done +# 20250911: This tool is no longer needed +OLD_FILES+=usr/tests/bin/cp/sparse + # 20250826: Remove a misspelled manual OLD_FILES+=usr/share/man/man3/sysdecode_syscallnames.3.gz diff --git a/bin/cp/tests/Makefile b/bin/cp/tests/Makefile index 3fa9ae8f0685..a1917ada8fbf 100644 --- a/bin/cp/tests/Makefile +++ b/bin/cp/tests/Makefile @@ -1,7 +1,5 @@ PACKAGE= tests ATF_TESTS_SH= cp_test -PROGS+= sparse -BINDIR= ${TESTSDIR} .include diff --git a/bin/cp/tests/cp_test.sh b/bin/cp/tests/cp_test.sh index 999993bfad67..fdf50d042f0b 100755 --- a/bin/cp/tests/cp_test.sh +++ b/bin/cp/tests/cp_test.sh @@ -384,7 +384,7 @@ samefile_body() file_is_sparse() { - atf_check ${0%/*}/sparse "$1" + atf_check -o match:"^[0-9]+-[0-9]" stat -h "$1" } files_are_equal() diff --git a/bin/cp/tests/sparse.c b/bin/cp/tests/sparse.c deleted file mode 100644 index 78957581a56c..000000000000 --- a/bin/cp/tests/sparse.c +++ /dev/null @@ -1,73 +0,0 @@ -/*- - * Copyright (c) 2023 Klara, Inc. - * - * SPDX-License-Identifier: BSD-2-Clause - */ - -#include -#include -#include -#include -#include -#include -#include - -static bool verbose; - -/* - * Returns true if the file named by its argument is sparse, i.e. if - * seeking to SEEK_HOLE returns a different value than seeking to - * SEEK_END. - */ -static bool -sparse(const char *filename) -{ - off_t hole, end; - int fd; - - if ((fd = open(filename, O_RDONLY)) < 0 || - (hole = lseek(fd, 0, SEEK_HOLE)) < 0 || - (end = lseek(fd, 0, SEEK_END)) < 0) - err(1, "%s", filename); - close(fd); - if (end > hole) { - if (verbose) - printf("%s: hole at %zu\n", filename, (size_t)hole); - return (true); - } - return (false); -} - -static void -usage(void) -{ - - fprintf(stderr, "usage: sparse [-v] file [...]\n"); - exit(EX_USAGE); -} - -int -main(int argc, char *argv[]) -{ - int opt, rv; - - while ((opt = getopt(argc, argv, "v")) != -1) { - switch (opt) { - case 'v': - verbose = true; - break; - default: - usage(); - break; - } - } - argc -= optind; - argv += optind; - if (argc == 0) - usage(); - rv = EXIT_SUCCESS; - while (argc-- > 0) - if (!sparse(*argv++)) - rv = EXIT_FAILURE; - exit(rv); -}