Date: Tue, 01 Sep 2015 08:37:35 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202737] [patch] audio/hydrogen: fix dependencies, add more options Message-ID: <bug-202737-13-g3aONkgFNs@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202737-13@https.bugs.freebsd.org/bugzilla/> References: <bug-202737-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202737 --- Comment #7 from FreeBSD@ShaneWare.Biz --- Some of the changes are useful some aren't. Adding LICENSE_FILE is not desired, hydrogen uses the gplv2 and multiple copies of the same license are not wanted. Cleanup of USE_QT4 - yes I should have looked at that a long time ago. Adding CFLAGS is not needed. Adding options DEBUG and TEST - not sure DEBUG and TEST would be needed outside of initial port testing but no harm. Adding librubberband support - this is an experimental feature that can be used in a -devel port but doesn't belong in a stable release. If a user installs audio/rubberband then hydrogen will use the cli tool to provide time stretching. While the rubberband port can be added as a dependency, hydrogen isn't really dependent on it, it will be used if it is there and ignored if it isn't. Disabling OSS does nothing, as oss is part of the base system hydrogen finds it and uses it even if you say you don't want it. The same goes for libarchive and libtar, hydrogen uses a tar format to combine multiple samples into one file, libarchive provides the same functionality with the addition of compression. If libarchive is found hydrogen will use it and ignore libtar, even if you say you don't want libarchive, as it is in the base system it will be found and libtar will never be use, so adding it as an option is pointless. The addition of USES=libarchive is useful so that the newer port version can be used. So the update I submit cleans up USE_QT4 and CMAKE_ARGS, adds libarchive to USES and adds DEBUG and TEST options. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202737-13-g3aONkgFNs>