From owner-freebsd-fs@FreeBSD.ORG Sun Oct 30 08:49:06 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACE17106564A; Sun, 30 Oct 2011 08:49:06 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (unknown [IPv6:2a01:4f8:150:6101::4]) by mx1.freebsd.org (Postfix) with ESMTP id 4697C8FC12; Sun, 30 Oct 2011 08:49:06 +0000 (UTC) Received: from core2.vx.sk (localhost [127.0.0.2]) by mail.vx.sk (Postfix) with ESMTP id 73F13B119; Sun, 30 Oct 2011 09:49:05 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk by core2.vx.sk (amavisd-new, unix socket) with LMTP id AVQbgn44kmX2; Sun, 30 Oct 2011 09:49:03 +0100 (CET) Received: from [10.9.8.1] (188-167-78-15.dynamic.chello.sk [188.167.78.15]) by mail.vx.sk (Postfix) with ESMTPSA id 55937B110; Sun, 30 Oct 2011 09:49:03 +0100 (CET) Message-ID: <4EAD0F7E.8030301@FreeBSD.org> Date: Sun, 30 Oct 2011 09:49:02 +0100 From: Martin Matuska User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Robert Millan References: <20111028200824.GA2757@thorin> In-Reply-To: <20111028200824.GA2757@thorin> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, Adrian Chadd Subject: Re: [PATCH] fix gratuitous dependencies in ZFS libraries / utilities X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2011 08:49:06 -0000 On 28. 10. 2011 22:08, Robert Millan wrote: > Hi, > > Some of the ZFS libraries and utilities are linked with libraries they > don't use: > > - zinject doesn't use libavl > - ztest doesn't use libz > - zdb uses neither libavl nor libz > - zfs uses neither libbsdxml nor libm, nor libsbuf > - zpool uses neither libbsdxml nor libm, nor libsbuf > > In addition, libzfs needs libm because it uses pow(), however it isn't > linked with -lm. This went unnoticed because all its users had -lm before. > > Attached patch (tested with "make buildworld") fixes these problems. Looks good + tested. -- Martin Matuska FreeBSD committer http://blog.vx.sk