From nobody Tue Jun 25 13:15:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7lhK6bfSz5PXY9; Tue, 25 Jun 2024 13:16:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7lhK6632z4gh3; Tue, 25 Jun 2024 13:16:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719321361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zo+w4lXP8NfRFoAu94Ffv7zlqiXGHzYpgtI2vGVHRQQ=; b=gVEgZS4CzwxtO/6m586zUc9cgJPlr5ctMiEvLNywd4/+06+L7xOkuMdvs7Gn6aJrGKVXC6 W0uSnXvYm33rzT4FHeA1Mphv6eHF+BXLAUcxv/mRh+sAX7yO+fiXclFVxSo6F623VxppM8 i8gmenWmrIs8/to3D8o4RmBkAwVtgZ+V0BZRGp7vACDD/tLEViDIRBm/B33LWaqExUms+k DD73L/XzJBggyiF6Gc4NmJdvzIQsD/xBZF83aCF6dTVIcrJmh5pOnRyljzUlxMIMel3AVY Ox4aHR35HS+L2WQz93K5j4HpSt4pofewsi92FYC034r5tJUPDf1SlQrTtnum5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719321361; a=rsa-sha256; cv=none; b=yRdcTIEPsE3TWrpNkkA+qa91CDvxJ+VAbu4igQf0iJYvYwpcbt0nX9gW4xM1djej7knTly sLw+DzKuQ0vY9vc92IyGXcL3TzA7egOQ9A/ujLazxfqnudlNW3fd0Nt7QMQFMRJw04pOAN CQFMOUcTWJhWOhwKKUWQ/MUumkk3C9u2Z7czWbTL49g9AX2r/X+0D/si7nUGT5lAdiXYrX PrDVaeoNxpTybN5ZTuV68FQoFbs8kS/29jkxoDR4YMlqOUJ0szX6BxToH8U9dRBZoEKuH1 35660Njcc5urn9otJtAfJRhm9jglt9ds3K2fLFirNWe3enPbK7uu3OLVaLmCmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719321361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zo+w4lXP8NfRFoAu94Ffv7zlqiXGHzYpgtI2vGVHRQQ=; b=kAbxPEQNMf/+vHjmtQ6QqyOoKyj4g/FMZ2ITnMAghKgRfN34kZA02K+PNRzhw/4fo5Cpmy Dy4DiwDOm7QeQcm9TdfWVnxxIi/ZpQWP6HmrYqAOY6meoVhYBIPZQc/U7oBWj5XQD3VxvH wiSvoHraJ0RP5yXRQumtFsWfIEGGkSCmgt8UUQurGYxVksTZzsj8wP+kWV5uTRwFIfXFVc Ldsr/aldMEwkfpVsWeDUyAh+1jVly8E8SUDOyFC0P0u38lTx37T6vwuy7QswCGdgR4hQyL vCxN4OpEnYfSZyaj3cntw5r1qvRrykUoqsllRpdxrtJsO1iALJW2S6GTB2MrzQ== Received: from ralga.knownspace (ip-163-182-7-56.dynamic.fuse.net [163.182.7.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4W7lhK3hVyzN9v; Tue, 25 Jun 2024 13:16:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Tue, 25 Jun 2024 09:15:59 -0400 From: Justin Hibbits To: Warner Losh Cc: Gleb Smirnoff , Warner Losh , src-committers , "" , "" Subject: Re: git: c2e9c5bbf022 - main - tpm: Refactor TIS and add a SPI attachment Message-ID: <20240625091559.2f258d3b@ralga.knownspace> In-Reply-To: References: <202405032032.443KWhf0045034@gitrepo.freebsd.org> <20240624161128.33c0f518@ralga.knownspace> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 24 Jun 2024 16:07:56 -0600 Warner Losh wrote: > On Mon, Jun 24, 2024, 3:16=E2=80=AFPM Gleb Smirnoff > wrote: >=20 > > On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote: =20 > > J> > sorry for late notice, but we just discovered that after this > > J> > commit tpm(4) on ACPI no longer attaches. From what I see > > J> > ther probe method isn't even called. =20 > > J> > > J> Hi Gleb, > > J> > > J> That's very odd. The probe method hasn't changed, nor has the > > J> tpm_acpi attachment (still acpi), so I'm really confused why it > > J> wouldn't be called now. Is there any debugging you can do to > > J> further narrow it down? I haven't seen any issues reported > > J> internally at Juniper on x86 hardware. I just verified > > J> everything should get built properly. =20 > > > > I started adding printfs to the probe method and as said - it is not > > even called. So I puzzled on where to start the debugging. I can > > test patches/ideas if you have any. > > > > Warner is also looking into this problem. > > =20 >=20 > I'm looking at name mismatched and/or moved parents to see if that's > in play. I thought I'd found something like this earlier, but it was > a false alarm I think. >=20 > Warner >=20 > > =20 I just saw bbecd3148abf. Sorry for the breakage, thanks for fixing it! - Justin