From nobody Tue Nov 5 01:33:47 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xj9pg4zLMz5cqHN; Tue, 05 Nov 2024 01:33:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xj9pg2BB3z4tJP; Tue, 5 Nov 2024 01:33:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730770427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a3yaYcKs5GTHVMrEUXRUhb7ADtKyJ99S0BEM2so85oo=; b=BMr3+GPYHvIqEgkrZt5HM54Azczh//LnbxnvRj7sREFzOSTJUgTrMBOWjDYJuh8pPTx1AI 6tnUF/xzJbBePlUrbsV50BwLJAzc0p5PzNeY5/Zexwye1fs7GZzJs6wjdAY8MlBFMYMiD2 CM21ZWo+MvRtO8vrRJwBb2HIjMUZIHk7fT/EbPD5O2XZcgcaYkjN8elrGSRXED72g9aagf ArVeAqU/tM0wkI/aWPY6A95bfrBqAYK3sxtwpFEml5TmFwb2OG5ExhGnc5vgqXDlPIRBOO XpFWpk7O+lrPymMdN2rqbIxXnkpg77EIeFLcx+Y9PU9OxbMnvLDYcKmsYfcrnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730770427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a3yaYcKs5GTHVMrEUXRUhb7ADtKyJ99S0BEM2so85oo=; b=pHWu6CZCJVs7hHtJ8MM5Mv6ljSyyQfUIy6fN+uG2okpwQ7BjW+zOKpE9L2jrU3ObBFaqWS NSNphmfvlvrSk7EPuw5JgMFWIecY6pkQVmMH1DO3NcdsvVF9UTRg/N1xgQ/zH5ED7VRkXi RGR3oK3sOsF3g9USnv9JZac/blhL7bkN5k9ycdlkSFIe3bsIyri5TrZhy6LysKjBW6swzp mKXxhjKYhTSy4c+N3buaDtGKL9WR381nlpVFCVqQj2toNKzaX4BLUkIbSCOU0lCo14YOkf pP6RQi1sgEpwtLJv1hEY9/KJP83FXO43Fce0fYca/4zqbEuyd52WLer3fJGj0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730770427; a=rsa-sha256; cv=none; b=JJGQDv0HmErNvIPhDrWoOXkKulIdMUTartLMk41vZ/92kgtZR3hdI7RniXNTxUDZMzu6yW O68ZsbEfcG9wP67dp9bmLcbqMJ+5U7n+RTroceWj4YdLclGogvtGsoYwLqVRdTbrxFYFSh ve+PfR4hRTnB/Dz+lrFGrmjVRLiWAKW0MJjMBdTTkmfGZ0S9ukcO4F92ykPaSqbIa0Hszu AofT4zFied9gR8JzTPLtf1qB61ObW8PuBLPO9X2wxaJ70wiPiD/pjz13+xno9egKXLp6at XbOZuY62GASi+HBDd/J6HA8/Ks1J2KBYD1XqDsAHDjclhPCrO7uzdZkYAdlFxQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xj9pg14cMzxYk; Tue, 5 Nov 2024 01:33:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A51XlCe049282; Tue, 5 Nov 2024 01:33:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A51XlG1049279; Tue, 5 Nov 2024 01:33:47 GMT (envelope-from git) Date: Tue, 5 Nov 2024 01:33:47 GMT Message-Id: <202411050133.4A51XlG1049279@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 8b54d874c70d - main - hifn/safe: Remove dummy calls to bus_generic_detach List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7 commit 8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7 Author: John Baldwin AuthorDate: 2024-11-05 01:31:30 +0000 Commit: John Baldwin CommitDate: 2024-11-05 01:31:30 +0000 hifn/safe: Remove dummy calls to bus_generic_detach These drivers do not add child devices, so there's no need to try to detach children. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47390 --- sys/dev/hifn/hifn7751.c | 2 -- sys/dev/safe/safe.c | 1 - 2 files changed, 3 deletions(-) diff --git a/sys/dev/hifn/hifn7751.c b/sys/dev/hifn/hifn7751.c index 23cf019b93a6..2e7545779b09 100644 --- a/sys/dev/hifn/hifn7751.c +++ b/sys/dev/hifn/hifn7751.c @@ -637,8 +637,6 @@ hifn_detach(device_t dev) crypto_unregister_all(sc->sc_cid); - bus_generic_detach(dev); /*XXX should be no children, right? */ - bus_teardown_intr(dev, sc->sc_irq, sc->sc_intrhand); /* XXX don't store rid */ bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq); diff --git a/sys/dev/safe/safe.c b/sys/dev/safe/safe.c index da2afbd38fad..c512f3fc62c0 100644 --- a/sys/dev/safe/safe.c +++ b/sys/dev/safe/safe.c @@ -464,7 +464,6 @@ safe_detach(device_t dev) mtx_destroy(&sc->sc_ringmtx); safe_dma_free(sc, &sc->sc_ringalloc); - bus_generic_detach(dev); bus_teardown_intr(dev, sc->sc_irq, sc->sc_ih); bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq);