From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 17 10:30:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B13F16A420 for ; Mon, 17 Dec 2007 10:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F2B3213C474 for ; Mon, 17 Dec 2007 10:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBHAU0g5059929 for ; Mon, 17 Dec 2007 10:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBHAU0Gn059928; Mon, 17 Dec 2007 10:30:00 GMT (envelope-from gnats) Resent-Date: Mon, 17 Dec 2007 10:30:00 GMT Resent-Message-Id: <200712171030.lBHAU0Gn059928@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Erik Cederstrand Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08BAF16A419 for ; Mon, 17 Dec 2007 10:22:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0BC7213C442 for ; Mon, 17 Dec 2007 10:22:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lBHAMclD033123 for ; Mon, 17 Dec 2007 10:22:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lBHAMcnH033122; Mon, 17 Dec 2007 10:22:38 GMT (envelope-from nobody) Message-Id: <200712171022.lBHAMcnH033122@www.freebsd.org> Date: Mon, 17 Dec 2007 10:22:38 GMT From: Erik Cederstrand To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/118770: PATCH: rc.d scripts: print information instead of silently failing when rcvar is not set X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2007 10:30:01 -0000 >Number: 118770 >Category: misc >Synopsis: PATCH: rc.d scripts: print information instead of silently failing when rcvar is not set >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Dec 17 10:30:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Erik Cederstrand >Release: 7.0-BETA4 >Organization: >Environment: FreeBSD blanc.affect-it.dk 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Sun Dec 2 19:19:04 UTC 2007 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: Starting an rc.d script without the corresponding rcvar variable set in rc.conf will silently fail. Printing a notice would be more helpful. >How-To-Repeat: # /etc/rc.d/ftpd start # .. but ftpd is not started >Fix: This patch to /etc/rc.subr notifies the user if the rc.d script is called without the rcvar set. # diff rc.subr.orig rc.subr 608a609 > echo "$name not started. Set ${rcvar} to YES in /etc./rc.conf or use '$name onestart'." which gives the output: # /etc/rc.d/ftpd start ftpd not started. Set ftpd_enable to YES in /etc./rc.conf or use 'ftpd onestart'. # >Release-Note: >Audit-Trail: >Unformatted: