From nobody Tue Mar 31 15:59:05 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flXqG3r2wz6WF71 for ; Tue, 31 Mar 2026 15:59:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flXqF6ZRRz3gwv for ; Tue, 31 Mar 2026 15:59:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774972746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SKvJ2BgdDPlYqp+ffE8geSncnfWgDSZ03J1t+DIQsyw=; b=Ax9EHXH7mMesqoPT0RvlfT7cfhbrcutLk0yGuf7zMIwmAQMxcbNK8C3ngxw77gVWm8O23+ GTi1oaWQhMCAcW2MfdxL4m+dioHL0b1SV3YTNVV06jawJDCiuI4wviBWN4pg/VCc4XV/a5 cCrjmm8MTS++yqo4VgKZOKEKw1Ck17dQk1vicnDEc5jhSl8OlpzKUrQLqihPtd6LAGbInM 4JJ4ur2jCpaUzGbRApN2YRqO3GEYLSE+/RyOtkmWAVU55ldP8Rcs0dqQNF5nodJbUfwKka sfZZUnL3oY/6BGg2/ZBKh7ZgbaMBxoPP47fqHV7cn2xkj8UUG5GoE5SIUCG5dw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774972746; a=rsa-sha256; cv=none; b=FfGUwgqpgp/TEwB2tvdUX79r+noKKGYAuK/aTebRD+PJGT1zejAdsYWhp3H4pxjpqjY28z iART4Uhv1xNQwCuzU0Iy2G+CrXqep74ICALIfpetKwJ+D1LJlsN4r0AT7OdOsDwZJ8KtLA BHGJOFx3NP8f/ZygN1ce3hW/q+A9KCVARaAk2IXZwzHlntGHVX/0fAwtZutWMJUJvWcBRm DtTqMx/oJi1Ayv66K2a6sZMcigS5uSDXO2pPDTC6yRMP06W8HFM+HLMXFT70BbTrtYtbzz u4KOz7Xxzez2Id4YJd5HIa1SofrZLkRQgzHOoexxPonJ2FYrvBngN3eJM/5DdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774972746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SKvJ2BgdDPlYqp+ffE8geSncnfWgDSZ03J1t+DIQsyw=; b=G1M7O32LnnI46f8MB0hWfdSUc2irr5bh+lr6k6u8GD1FGHznG4R99+eV8R30Zu5H3OL6zN SrmP5S09492s4SvQn04lfHgbriUfMvE97vBkLaQifxEOkK/xe2/mYWorQB2oKBa+D8BwyZ zDvDzD7cJhW1ZDwiC0du5+strkB0n2jaVgeUh2WYd7yWdqyPiOXpQfZBWnjZtmZtY7F67D 16Q4a5aRnX3/Mi9qReDLbhg11AmiTmG7R8ZL70HrwHH+6qIslF9XyoPcMdTk83x1wjrcVQ zbYyaLLlCwPZ9BBAPi3EULwKGfUhxdSnMGbvvNFwCY4rHHgrcEAJp6LLwbeYKA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flXqF4G0Vzcc6 for ; Tue, 31 Mar 2026 15:59:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 395f8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 31 Mar 2026 15:59:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 5f7525c0210c - stable/15 - pipe: Avoid unnecessary priv_check() calls in pipespace_new() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5f7525c0210c9ef8e06b7b3c7e6049e356fad009 Auto-Submitted: auto-generated Date: Tue, 31 Mar 2026 15:59:05 +0000 Message-Id: <69cbef49.395f8.44cb96b1@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5f7525c0210c9ef8e06b7b3c7e6049e356fad009 commit 5f7525c0210c9ef8e06b7b3c7e6049e356fad009 Author: Mark Johnston AuthorDate: 2026-02-21 16:28:49 +0000 Commit: Mark Johnston CommitDate: 2026-03-31 15:57:29 +0000 pipe: Avoid unnecessary priv_check() calls in pipespace_new() Running out of pipe map KVA is a rare case, so reorder checks accordingly, presuming that calling priv_check() is more expensive than the calculation. In particular, priv_check() might not be cheap to evaluate if MAC hooks are installed. Reviewed by: olce, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D55378 (cherry picked from commit fa77660a3ccbd5f30e88093703b0f93892ef35d7) --- sys/kern/sys_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c index b319f0ac9c53..e5a49ef3a526 100644 --- a/sys/kern/sys_pipe.c +++ b/sys/kern/sys_pipe.c @@ -600,8 +600,8 @@ retry: } vm_map_lock(pipe_map); - if (priv_check(curthread, PRIV_PIPEBUF) != 0 && maxpipekva / 100 * - (100 - pipebuf_reserv) < amountpipekva + size) { + if (maxpipekva / 100 * (100 - pipebuf_reserv) < amountpipekva + size && + priv_check(curthread, PRIV_PIPEBUF) != 0) { vm_map_unlock(pipe_map); chgpipecnt(cpipe->pipe_pair->pp_owner->cr_ruidinfo, -size, 0); if (cpipe->pipe_buffer.buffer == NULL &&