From owner-svn-src-all@FreeBSD.ORG Thu Jul 10 13:52:59 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EEBDC21A; Thu, 10 Jul 2014 13:52:58 +0000 (UTC) Received: from mail-we0-x22c.google.com (mail-we0-x22c.google.com [IPv6:2a00:1450:400c:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 314AE2D6E; Thu, 10 Jul 2014 13:52:58 +0000 (UTC) Received: by mail-we0-f172.google.com with SMTP id u57so9154044wes.31 for ; Thu, 10 Jul 2014 06:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=p2E6GOcWb2KaJmdN6ajWf+YChnx4onppKPJMiofvtgw=; b=i1kEdW7xwabDui73GGun9UkhCxmt13Iblmqq31nqNK+oVl7QWLVoze3jjIlvNGLIz9 bka2fmjbTCO9MFg8wLY0QTIGOuFqF3AifszdcJOcskxfxSNsQcCffObtps3Q3GQfQV+T sgesyldvNrVquM6fMoZxbHQXWMmiKsCXQYN3+yKpnhDG8ON0bN2rjHJnBWIlZ6Y1wwaO s0w1F9pyCpkJEF1wzt+0ZXiuMTxAcBvLUmRKTa2xTPOWr+y1QarWcZePJXyRcKCJO8CD 50gncbe31z/3xwSoUNp5GoHRmOzx8vqS4WtKG4gSflrnfPio6jzp7vN+zDvyoDkdPAvi 8KnA== X-Received: by 10.194.77.177 with SMTP id t17mr54680066wjw.55.1405000376442; Thu, 10 Jul 2014 06:52:56 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id cz4sm32030181wib.23.2014.07.10.06.52.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jul 2014 06:52:55 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 10 Jul 2014 15:52:53 +0200 From: Baptiste Daroussin To: Konstantin Belousov Subject: Re: svn commit: r268493 - head/lib/libfetch Message-ID: <20140710135253.GA93051@ivaldir.etoilebsd.net> References: <201407101304.s6AD4rne079137@svn.freebsd.org> <20140710132813.GQ93733@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20140710132813.GQ93733@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 13:52:59 -0000 --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 10, 2014 at 04:28:13PM +0300, Konstantin Belousov wrote: > On Thu, Jul 10, 2014 at 01:04:53PM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Thu Jul 10 13:04:52 2014 > > New Revision: 268493 > > URL: http://svnweb.freebsd.org/changeset/base/268493 > >=20 > > Log: > > Support EAGAIN in fetch_writev > > =20 > > Reviewed by: des > > Approved by: des > >=20 > > Modified: > > head/lib/libfetch/common.c > >=20 > > Modified: head/lib/libfetch/common.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libfetch/common.c Thu Jul 10 12:41:58 2014 (r268492) > > +++ head/lib/libfetch/common.c Thu Jul 10 13:04:52 2014 (r268493) > > @@ -1110,6 +1110,8 @@ fetch_writev(conn_t *conn, struct iovec=20 > > errno =3D 0; > > pfd.revents =3D 0; > > if (poll(&pfd, 1, deltams) < 0) { > > + if (errno =3D=3D EAGAIN) > > + continue; > > if (errno =3D=3D EINTR && fetchRestartCalls) > > continue; > > return (-1); >=20 > How is this error possible ? poll(2) converts EAGAIN from seltdwait(9) > to no error. For posix compliance, libfetch is not only used on FreeBSD, reading at: http://pubs.opengroup.org/onlinepubs/009695399/functions/poll.html I can re= ad: [EAGAIN] The allocation of internal data structures failed but a subsequent requ= est may succeed. Am I missing something? Bapt --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlO+mrUACgkQ8kTtMUmk6EzSZwCgm7nFamyduDHSejQXFMoTYpgf WQkAn2+Vl5/4PGM7TRkkUx4CRsWo+LNE =P4ab -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--