From owner-freebsd-ppc@FreeBSD.ORG  Thu Jun  2 08:26:19 2005
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
X-Original-To: freebsd-ppc@freebsd.org
Delivered-To: freebsd-ppc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0ACC116A41C;
	Thu,  2 Jun 2005 08:26:19 +0000 (GMT) (envelope-from obrien@NUXI.com)
Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BA75943D1F;
	Thu,  2 Jun 2005 08:26:18 +0000 (GMT) (envelope-from obrien@NUXI.com)
Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1])
	by dragon.NUXI.org (8.13.3/8.13.3) with ESMTP id j528QHhW036196;
	Thu, 2 Jun 2005 01:26:17 -0700 (PDT)
	(envelope-from obrien@dragon.NUXI.org)
Received: (from obrien@localhost)
	by dragon.NUXI.org (8.13.3/8.13.1/Submit) id j528QFXV036195;
	Thu, 2 Jun 2005 01:26:15 -0700 (PDT) (envelope-from obrien)
Date: Thu, 2 Jun 2005 01:26:15 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Jung-uk Kim <jkim@niksun.com>
Message-ID: <20050602082615.GA36096@dragon.NUXI.org>
Mail-Followup-To: obrien@freebsd.org, Jung-uk Kim <jkim@niksun.com>,
	freebsd-amd64@freebsd.org, freebsd-ia64@freebsd.org,
	freebsd-alpha@freebsd.org, freebsd-ppc@freebsd.org
References: <429D860A.5000608@club-internet.fr>
	<Pine.SOC.4.61.0506011555050.28761@tea.blinkenlights.nl>
	<429DFEA1.8000004@club-internet.fr>
	<200506011833.12686.jkim@niksun.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200506011833.12686.jkim@niksun.com>
X-Operating-System: FreeBSD 6.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
User-Agent: Mutt/1.5.9i
Cc: freebsd-ppc@freebsd.org, freebsd-alpha@freebsd.org,
	freebsd-amd64@freebsd.org, freebsd-ia64@freebsd.org
Subject: Re: [CALL FOR TESTERS] ReiserFS on non-i386 hardware patch
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2005 08:26:19 -0000

On Wed, Jun 01, 2005 at 06:33:12PM -0400, Jung-uk Kim wrote:
> The kernel module doesn't load because of an amd64-specific GCC 3.4
> optimization bug.  To work around:
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/sys/modules/reiserfs/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- Makefile    24 May 2005 12:30:13 -0000      1.1
> +++ Makefile    1 Jun 2005 22:22:52 -0000
> @@ -8,4 +8,8 @@
>         reiserfs_namei.c reiserfs_prints.c reiserfs_stree.c \
>         reiserfs_vfsops.c reiserfs_vnops.c
>  
> +.if ${MACHINE_ARCH} == "amd64"
> +CFLAGS+=       -minline-all-stringops
> +.endif
> +

Unfortunately we really don't like to put this type of CFLAGS in non-*.mk
files.  Since we know the GCC 3.4.2 compiler bugs will be fixed, I
suggest we just document this issue and be happy that otherwise the code
is ready to go on FreeBSD/amd64.

-- 
-- David  (obrien@FreeBSD.org)