From owner-svn-src-all@FreeBSD.ORG Sun Jan 18 09:47:51 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B42221065676; Sun, 18 Jan 2009 09:47:51 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-bw0-f16.google.com (mail-bw0-f16.google.com [209.85.218.16]) by mx1.freebsd.org (Postfix) with ESMTP id A70AC8FC08; Sun, 18 Jan 2009 09:47:50 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by bwz9 with SMTP id 9so10185bwz.19 for ; Sun, 18 Jan 2009 01:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qsL2PiNGet4aA1v6u3P/il6yFcSYu3ubUiH211OBTOk=; b=OmK0rlYkLMo32sYmX/LPXLPMoGxNHSsThM8/Gm+dugzYM2LpcfA5vnhJ886JjulxSX MM22wjRcRBgMCVTnie1kXRT9IbGyQ2ivMMwNHn9+MHlYAH+vE6ZKKW2i9y/axEkYwvVM rxOUzM51O8F6yq4TNeYhuABS9HM23h/ziCduM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=TvHhlR/fGCIz2IkQGKWiG1k/pF40hMNbnGOf+IOtF0iZCwprRvhmLFHaPjTkxZQiYy RRTnDYa3QCJMoJJV9H+Bfm9rDkv6Z4jH/QxTrZsMW2kwQiYjrgYx77w+rASW0HYUNzvg Yk3ngN9OnqVKMVVERk2vOp6aQs2SBSsVANp2Q= MIME-Version: 1.0 Received: by 10.180.224.4 with SMTP id w4mr1598571bkg.174.1232272007318; Sun, 18 Jan 2009 01:46:47 -0800 (PST) In-Reply-To: <200901172301.n0HN1ePm054707@svn.freebsd.org> References: <200901172301.n0HN1ePm054707@svn.freebsd.org> Date: Sun, 18 Jan 2009 01:46:47 -0800 Message-ID: <7d6fde3d0901180146v4fe098abmd526e2a2c869282b@mail.gmail.com> From: Garrett Cooper To: Ed Schouten Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187374 - head/sys/dev/syscons/teken X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2009 09:47:52 -0000 On Sat, Jan 17, 2009 at 3:01 PM, Ed Schouten wrote: [...] > Modified: > head/sys/dev/syscons/teken/teken_subr_compat.h > > Modified: head/sys/dev/syscons/teken/teken_subr_compat.h > ============================================================================== > --- head/sys/dev/syscons/teken/teken_subr_compat.h Sat Jan 17 22:53:53 2009 (r187373) > +++ head/sys/dev/syscons/teken/teken_subr_compat.h Sat Jan 17 23:01:40 2009 (r187374) > @@ -33,20 +33,23 @@ teken_subr_cons25_set_cursor_type(teken_ > teken_funcs_param(t, TP_SHOWCURSOR, type != 1); > } [...] Dumb question: Why are C function definitions in a .h file? I know it's legal, but at least from what I've been coached on in the past, it isn't necessarily the most kosher way of solving the issue. Macros are a different point. Thanks, -Garrett