From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 22:12:15 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BF1716A41C for ; Mon, 6 Jun 2005 22:12:15 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 1CEA343D49 for ; Mon, 6 Jun 2005 22:12:15 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 49359 invoked by uid 399); 6 Jun 2005 22:12:13 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 6 Jun 2005 22:12:13 -0000 Message-ID: <42A4CA37.1050201@FreeBSD.org> Date: Mon, 06 Jun 2005 15:12:07 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050326) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "J.R. Oldroyd" References: <20050603143803.GP886@linwhf.opal.com> In-Reply-To: <20050603143803.GP886@linwhf.opal.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 22:12:15 -0000 J.R. Oldroyd wrote: > I posted this to -current yesterday; it was suggested I resend to > this list. Thanks for bringing this up, and yes, we prefer discussion here on rc.d topics. > ----- Forwarded message from "J.R. Oldroyd" ----- > > From: "J.R. Oldroyd" > Date: Thu, 2 Jun 2005 17:10:23 -0400 > Subject: Use of rcorder for local rc.d/*.sh scripts > To: freebsd-current@freebsd.org > > Is there a reason that rcorder is not used in /etc/rc.d/localpkg > so that the scripts there can be ordered using their tags? > > If not, could we make the following change to /etc/rc.d/localpkg: > > --- localpkg.orig Fri Oct 8 13:52:43 2004 > +++ localpkg Thu Jun 2 16:53:56 2005 > @@ -36,7 +36,7 @@ > done > script_save_sep="$IFS" > IFS="${script_name_sep}" > - for script in ${slist}; do > + for script in `rcorder -s nostart ${slist} 2>/dev/null`; do This is an interesting approach. I'm in favor of incorporating rcorder for local scripts (whether ports, or homegrown stuff), but I think I prefer an approach that brings all the scripts into the fray, so that local scripts that need to execute before parts of the base can do so. Have you put any thought into such an approach? > If we do, there may be some scripts that ports install in the > local/etc/rc.d dirs that need rcorder tags adding, notably those > that currently use "000.foo.sh" names to ensure they're started > first. Yeah, if we're going to do something like this, it would be nice to do it before the 6.0 code slush, so if we can at least agree in principle that it should be done, and roughly on how, then we can send a message to the -ports list with a heads up on this topic. The ports code freeze comes after the base, so there will be time to fix ports that are broken by this change. Doug -- This .signature sanitized for your protection