From owner-freebsd-net@FreeBSD.ORG Tue May 13 05:23:23 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB0A8C76 for ; Tue, 13 May 2014 05:23:23 +0000 (UTC) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BA072CC8 for ; Tue, 13 May 2014 05:23:23 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id rd3so9811760pab.15 for ; Mon, 12 May 2014 22:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=cHJZFF5zrvGlGGOqvOV90m6bVt9nRZFiKTZbiHYshyw=; b=dJVyIvfF7y94uHal8Lwp8/U/tnLwCSH/s3zGEbKyBNyUWLoNbGwT3RIyfvPqKd+2Wr os8n4YGLHHp6HoWSvZ7jQA/IvW1xlGqpXBPO4VGfHijBofkCgkby8gqXMv2H0q/z9vOp t+aR8wskUP44NZ/Gs9dUpqqovRptVeLHlo/xzmGfyVuuN1p3aUsqIuUD1rv/yw5Bd20p zgArd6XshFowrJifAL2apEShlNIjoYvZxChRuXKxsfZczboLkruIPU7jWPflN0LdkCBw fFKybjoVm98jD4wB82qRzr0/zD8JE7KK+TSA46Uj104WQ/GJD/E8qE8iumbiuAtrA9RV GWOg== X-Received: by 10.69.26.103 with SMTP id ix7mr2731968pbd.41.1399958603282; Mon, 12 May 2014 22:23:23 -0700 (PDT) Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249]) by mx.google.com with ESMTPSA id wp3sm25926634pbc.67.2014.05.12.22.23.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 12 May 2014 22:23:22 -0700 (PDT) X-Google-Original-From: "Yonghyeon PYUN" Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 13 May 2014 14:23:19 +0900 From: Yonghyeon PYUN Date: Tue, 13 May 2014 14:23:19 +0900 To: Michael Tuexen Subject: Re: TX Checksum offloading issue with re interfaces Message-ID: <20140513052319.GB1419@michelle.cdnetworks.com> Reply-To: pyunyh@gmail.com References: <95E18108-E6DD-49EA-90B3-A9F9E5F93D20@lurchi.franken.de> <20140509014733.GB3014@michelle.cdnetworks.com> <20140512043837.GA1364@michelle.cdnetworks.com> <4DCF8CB0-220E-4BC4-AF71-E84CCDA88315@lurchi.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DCF8CB0-220E-4BC4-AF71-E84CCDA88315@lurchi.franken.de> User-Agent: Mutt/1.4.2.3i Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2014 05:23:23 -0000 On Mon, May 12, 2014 at 01:09:18PM +0200, Michael Tuexen wrote: > On 12 May 2014, at 06:38, Yonghyeon PYUN wrote: > > > On Fri, May 09, 2014 at 12:33:24PM +0200, Michael Tuexen wrote: > >> On 09 May 2014, at 03:47, Yonghyeon PYUN wrote: > >> > >>> On Thu, May 08, 2014 at 08:50:48PM +0200, Michael Tuexen wrote: > >>>> Dear all, > >>>> > >>>> while testing checksum offloading of UDP packets over IP with IP options, I figured > >>>> out that my card > >>>> > >>>> dev.re.1.%desc: RealTek 8168/8111 B/C/CP/D/DP/E/F/G PCIe Gigabit Ethernet > >>>> dev.re.1.%driver: re > >>>> dev.re.1.%location: slot=0 function=0 handle=\_SB_.PCI0.PE1F.LAN2 > >>>> dev.re.1.%pnpinfo: vendor=0x10ec device=0x8168 subvendor=0x1734 subdevice=0x1159 class=0x020000 > >>>> dev.re.1.%parent: pci13 > >>>> dev.re.1.stats: -1 > >>>> dev.re.1.int_rx_mod: 65 > >>>> > >>>> computes the UDP checksum, but stores it in the packet at the place, where it would be, > >>>> if there are no IP options. So it corrupts the options in the packet... > >>>> > >>>> I looked at sys/dev/re/if_re.c, but couldn't figure out how to fix it. Any idea? > >>>> > >>> > >>> re(4) has a very long history on its broken TX checksum offloading. > >>> So re(4) has many workarounds for known issues on several variants. > >>> re(4) controllers support TX IPv4/TCP/UDP checksum offloading. For > >>> 8168C/8168CP, TX IPv4 checksum offloading was disabled due to > >>> generation of corrupted frames. > >>> Could you show me the dmesg output(only re(4)/rgephy(4))? > >> > >>> The vendor uses the same PCI id for its RTL8168/8111 family chips > >>> so dmesg output is necessary to know exact controller revision. > >> Sure (re1 was used during the test): > >> re0: port 0x8000-0x80ff mem 0xf6104000-0xf6104fff,0xf6100000-0xf6103fff irq 16 at device 0.0 on pci12 > >> re0: Using 1 MSI-X message > >> re0: Chip rev. 0x28800000 > >> re0: MAC rev. 0x00200000 > >> miibus0: on re0 > >> rgephy0: PHY 1 on miibus0 > >> rgephy0: none, 10baseT, 10baseT-FDX, 10baseT-FDX-flow, 100baseTX, 100baseTX-FDX, 100baseTX-FDX-flow, 1000baseT, 1000baseT-master, 1000baseT-FDX, 1000baseT-FDX-master, 1000baseT-FDX-flow, 1000baseT-FDX-flow-master, auto, auto-flow > >> re0: Ethernet address: 00:19:99:85:31:d9 > >> re1: port 0x9000-0x90ff mem 0xf5c20000-0xf5c20fff,0xf6200000-0xf620ffff irq 17 at device 0.0 on pci13 > >> re1: Using 1 MSI-X message > >> re1: Chip rev. 0x3c800000 > >> re1: MAC rev. 0x00300000 > >> miibus1: on re1 > >> rgephy1: PHY 1 on miibus1 > >> rgephy1: none, 10baseT, 10baseT-FDX, 10baseT-FDX-flow, 100baseTX, 100baseTX-FDX, 100baseTX-FDX-flow, 1000baseT, 1000baseT-master, 1000baseT-FDX, 1000baseT-FDX-master, 1000baseT-FDX-flow, 1000baseT-FDX-flow-master, auto, auto-flow > >> re1: Ethernet address: 00:19:99:7e:c7:46 > >> > > It seems you have two variants. > You are right, I didn't know. Both are on-board interfaces... > > re0 is RTL8168DP and re1 is RTL8168CP. Do you see the issue on > > both controllers? I guess you may see the issue on re1 only since > > you've posted dev.re.1 output. I've attached a diff which may > It wasn't intentionally, but by accident, based on the addresses > I was using. However, I now tested both interfaces and re0 works > without any patch, but re1 needs your patch. > > address the issue on re1 interface. If you see the issue on re0, > > I have to change the diff to include RTL8168D. > Your patch looks good. Please go ahead and commit it. > Thanks for your help! Fixed in r265943. Thanks for testing!