Date: Sat, 23 Dec 2023 08:54:41 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Muhammad Moinur Rahman <bofh@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e4b7e0154f5e - main - Mk/bsd.options.desc.mk: Expand ASLR Message-ID: <kyqqa5kletachgdhqhtorvu52dn5ojquwt6lumfpljv7cbxau7@wzzdrme5yxcy> In-Reply-To: <202312222344.3BMNivih098673@gitrepo.freebsd.org> References: <202312222344.3BMNivih098673@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--jd7glpsgsv7m6l3h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 22, 2023 at 11:44:57PM +0000, Muhammad Moinur Rahman wrote: > diff --git a/Mk/bsd.options.desc.mk b/Mk/bsd.options.desc.mk > index d20740cc888a..f877b04dd8d4 100644 > --- a/Mk/bsd.options.desc.mk > +++ b/Mk/bsd.options.desc.mk > @@ -30,7 +30,7 @@ APE_DESC?=3D Monkey's Audio lossless format support > ARCHIVE_DESC?=3D bzip2/zip/iso9660 archive support > ARMADILLO_DESC?=3D TPS transform computation via Armadillo > ASIO_DESC?=3D Asynchronous I/O support > -ASLR_DESC?=3D Enable ASLR support > +ASLR_DESC?=3D Enable Address Space Layout Randomization support > ASM_DESC?=3D Use optimized assembly code > ASPELL_DESC?=3D Spell checking support via GNU Aspell > ASSERT_DESC?=3D Enable debug assertions To be a bit pedantic, it still means little to the user, does it mean it will build stuff with the random bits, or that it adds random bits to stuff when running... The option has to describe what will change if enabled, all the options that have description saying "enable foo support" are quite useless, of course enabling option foo will enable foo in some way, the important information is what it actually does. In this short diff hunk, the only options with meaningfull descriptions are ARMADILLO and ASPELL. ASM is somewhat ok even if a bit too generic. All other are almost useless, they are very generic and mean very little in any port. --=20 Mathieu Arnold --jd7glpsgsv7m6l3h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmWGkkBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5IgQv/SoqZsWhMEunDLNOBF68TNl80HuIf+nIL+05ylC18OPV3vF9EvdnZquHZ mz1mxRGHSq9lqvw8HovPEGkQ2p7CanG88m9eMf7cFDI/K1hb4BknjXRRyO30o2tU FCCJwcipEYpSsxepfXD+Mkwo3H2ImLQt6g77MMnzGxRO6lP2bGYogh3T/0RLx7zk Ez6vh3gpoCvFjRJbc2tcYDlGR/s35Gx1J7Hp00PeC9lx6QIGa1xayAwZkSX0wC4G Pf9VOre5hHePKpeScvpK451Pi1WkO3IIBj4z7BrAVjfn1s9JCzxtDp/48G4ajgC5 rAoceOCR4GUoDxiPGZqmvuYZQJwSNluX02RIrKHWbGs+ShN2fVTRwqrzBh41hBSE 0zUTOunPep/UvgF7uOCxnKSNXUJ7QpuddruuY7sPl9czCM/HlTJqMQFoT2rVVNHW ljzzuGDOMl66IxnRAqxKhmooQLQDcevXEFw2bgdhntfuc9QG0gCxR9OCEzDcwod1 5LEAX+5B =gBqC -----END PGP SIGNATURE----- --jd7glpsgsv7m6l3h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?kyqqa5kletachgdhqhtorvu52dn5ojquwt6lumfpljv7cbxau7>