From owner-freebsd-current@FreeBSD.ORG Sat Jun 23 16:52:44 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3942E106566B for ; Sat, 23 Jun 2012 16:52:44 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm20.bullet.mail.sp2.yahoo.com (nm20.bullet.mail.sp2.yahoo.com [98.139.91.90]) by mx1.freebsd.org (Postfix) with SMTP id 0E9728FC0A for ; Sat, 23 Jun 2012 16:52:44 +0000 (UTC) Received: from [72.30.22.78] by nm20.bullet.mail.sp2.yahoo.com with NNFMP; 23 Jun 2012 16:52:38 -0000 Received: from [72.30.22.39] by tm12.bullet.mail.sp2.yahoo.com with NNFMP; 23 Jun 2012 16:52:38 -0000 Received: from [127.0.0.1] by omp1069.mail.sp2.yahoo.com with NNFMP; 23 Jun 2012 16:52:38 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 745832.23722.bm@omp1069.mail.sp2.yahoo.com Received: (qmail 15665 invoked by uid 60001); 23 Jun 2012 16:52:38 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1340470358; bh=la9i6PAdjgAZmz+N9K/uOblyQ3H0WekzdMDOLewMl9Q=; h=X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=JQEcICUJ1aCVlhzVOjV3bah/4oFSvBwmDPbQAglJ8fvE+xCngPCfXCJX4CspH8IQdWBFgY4x8sXhKm6KRjC2M9AzG/lsgAMqxWQCgs/jOnfxBslcWsWurKl4iPmhVFgFuj1OtZl7TjK0rDKOBtOBGLyl0nFV2EbNuCUSpLUjzNU= X-YMail-OSG: dVLafgsVM1m2Xtw99fBJN1jqROXc.pU7mm1g2Ah.JxDZoVR iVjSB_aPGOGxRNeGQsIBmYtXxnVDHpLNsUWzBAgBzdhvqVcWfqeS3q2vS1s1 4GFz.frPWPvqfLyEQNlX0BEBW6y.YnF239PW1HueX.ceeJfw0AEwj28SntRB 5D1aybpZVqqNXurkeng_IINxqFVcNmqORutuke94QKt1ELFV.fyQiPtgNM0R FVSCzan6WH2l.QbcgthWsFN3mJRTKD__4hFxDSzsWywc7RCBNurgUK2Wcbir uxOKVOBbda8J2TjMH0g5mcP8B8y9XtwAKSMQ.cGoqfZVTLBcuoYJOmmP9EEc M9NwHhmP9B.HuZon4CCMnlBK9dU.IkT7eR0b0.bxb7pHnC3aUjiufCeczpyx .b.DKb6hY_U_05uFJ5MpGf4m3MIRRqeKCDIBr9ck2VlepFkQPF9ugL4ZmaEI vJe.hdfTdnBn69xvgq5EOoxGL4F2mf4OlAV9jgh9wfWfHSjs57T5OOHLw4DB rZn8zIOVr1jc7oe9eaJHQBnrgvCDC7v3QLl9SF1.G Received: from [200.118.157.7] by web113519.mail.gq1.yahoo.com via HTTP; Sat, 23 Jun 2012 09:52:38 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/15.0.8 YahooMailWebService/0.8.118.349524 Message-ID: <1340470358.2705.YahooMailClassic@web113519.mail.gq1.yahoo.com> Date: Sat, 23 Jun 2012 09:52:38 -0700 (PDT) From: Pedro Giffuni To: freebsd-current@FreeBSD.org In-Reply-To: <20120623133624.3433ec78@fabiankeil.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: [RFT] llquantize for FreeBSD's dtrace X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pfg@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2012 16:52:44 -0000 Hello Fabian;=0A=0A--- Sab 23/6/12, Fabian Keil ha scritto:=0A=0A> Pedro Gi= ffuni wrote:=0A> =0A> > I am not a Dtrace user (yet) but = I started to port the=0A> Log/linear=0A> > quantizations from Illumos:=0A> = > =0A> > http://dtrace.org/blogs/bmc/2011/02/08/llquantize/=0A> > =0A> > Ap= parently this patch should do it:=0A> > =0A> > http://people.freebsd.org/~p= fg/patches/patch-llquantize-complete=0A> > =0A> > Unfortunately when I trie= d to build current with Dtrace=0A> > support, my i386 Virtualbox VM got stu= ck in ctfmerge so=0A> > this is completely untested.=0A> > =0A> > Testers t= hat know how to use it are welcome :).=0A> =0A> I applied it on 10-CURRENT = amd64 from /usr/src with patch=0A> -p0 without any conflicts, but it doesn'= t appear to be=0A> working.=0A> =0A> The example from the blog post above t= riggers an assertion=0A> that is still reproducible when reducing the test = case:=0A> =0A> fk@r500 /tmp $sudo dtrace -n 'tick-1ms{@ =3D llquantize(i++,= =0A> 10, 0, 6, 20);}'=0A> Assertion failed: (!(arg & (UINT16_MAX <<=0A> arg= s[i].shift))), file=0A> /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/o= pensolaris/lib/libdtrace/common/dt_cc.c,=0A> line 1429.=0A>=0A=0AThanks for= testing!=0A=0AIt seems like the syntax has changed from the time the=0Aexa= mple from the blog was made. The code says:=0A=0A/*=0A * For log/linear qua= ntizations, we have between one and five=0A * arguments in addition to the = expression:=0A *=0A * arg1 =3D> Factor=0A * arg2 =3D> Low magnitude= =0A * arg3 =3D> High magnitude=0A * arg4 =3D> Number of steps per mag= nitude=0A * arg5 =3D> Quantization increment value (defaults to 1)=0A */= =0A=0A=0AMy suggestion would be to instead try using the test=0Ascripts in= =0Acddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/=0A=0Aerr= .D_LLQUANT_FACTORSMALL.d (for example) has=0A=0A@ =3D llquantize(0, 1, 0, 1= 0, 10);=0A=0Ahope that helps!=0A=0APedro.=0A=0A