From owner-cvs-src@FreeBSD.ORG Fri Oct 12 21:55:06 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D562816A417; Fri, 12 Oct 2007 21:55:06 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 95A7F13C467; Fri, 12 Oct 2007 21:55:06 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id B9DC941C733; Fri, 12 Oct 2007 23:55:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id XCGpEltWcKWV; Fri, 12 Oct 2007 23:55:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 5EB3D41C72F; Fri, 12 Oct 2007 23:55:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 04A96444885; Fri, 12 Oct 2007 21:51:17 +0000 (UTC) Date: Fri, 12 Oct 2007 21:51:17 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Maksim Yevmenkin In-Reply-To: Message-ID: <20071012213609.X6043@maildrop.int.zabbadoz.net> References: <200710121635.l9CGZbO2063862@repoman.freebsd.org> <20071012200336.H6043@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d ppp X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2007 21:55:06 -0000 On Fri, 12 Oct 2007, Maksim Yevmenkin wrote: > On 10/12/07, Bjoern A. Zeeb wrote: >> On Fri, 12 Oct 2007, Maksim Yevmenkin wrote: >> >>> emax 2007-10-12 16:35:36 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> etc/defaults rc.conf >>> etc/rc.d ppp >>> Log: >>> Teach /etc/rc.d/ppp to start multiple instances of ppp. >>> >>> ppp_profile variable can now contain multiple profiles. >>> Overrides for ppp mode and nat can go into ppp_$profile_mode >>> and ppp_$profile_nat variables respectively. If those are >>> not specified, defaults from ppp_mode and ppp_nat are used. >>> >>> Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru > >>> Reviewed by: mtm >>> MFC after: 1 week >>> >>> Revision Changes Path >>> 1.319 +6 -0 src/etc/defaults/rc.conf >>> 1.14 +43 -9 src/etc/rc.d/ppp >>> >> which should also provide a fallback to the global >> setting in case the _profile on is not given... > > the version i have committed provides fallback to default ppp_mode and > ppp_nat if profile specific mode and nat overrides were omitted. Ah. Yes. Looked at the new version, not just half of the change;) Seems yours is a lot better worked out and looks way cleaner:-) Two comments: a) do we really need that su -c ""? I have no idea what ppp_user had done so far (did anything)? b) could you grab that last change, that rc.d/jail has as well, so it would be possible to start/stop/.. a single instance by giving the profile name after the start/stop/...? -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time.