From owner-freebsd-current@FreeBSD.ORG Wed Apr 29 18:40:08 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18137106568B for ; Wed, 29 Apr 2009 18:40:08 +0000 (UTC) (envelope-from ben@wanderview.com) Received: from mail.wanderview.com (mail.wanderview.com [66.92.166.102]) by mx1.freebsd.org (Postfix) with ESMTP id ABCC58FC21 for ; Wed, 29 Apr 2009 18:40:07 +0000 (UTC) (envelope-from ben@wanderview.com) Received: from harkness.in.wanderview.com (harkness.in.wanderview.com [10.76.10.150]) (authenticated bits=0) by mail.wanderview.com (8.14.3/8.14.3) with ESMTP id n3TIe3Fe002424 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Wed, 29 Apr 2009 18:40:03 GMT (envelope-from ben@wanderview.com) Message-Id: From: Ben Kelly To: current@freebsd.org In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Wed, 29 Apr 2009 14:40:02 -0400 References: <4D8E4457-89AA-4F19-9960-E090D3B8E319@wanderview.com> <20090429064303.GA2189@a91-153-125-115.elisa-laajakaista.fi> X-Mailer: Apple Mail (2.930.3) X-Spam-Score: -1.44 () ALL_TRUSTED X-Scanned-By: MIMEDefang 2.64 on 10.76.20.1 Cc: Subject: Re: [patch] zfs livelock and thread priorities X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2009 18:40:08 -0000 On Apr 29, 2009, at 7:58 AM, Ben Kelly wrote: > On Apr 29, 2009, at 2:43 AM, Jaakko Heinonen wrote: >> On 2009-04-28, Ben Kelly wrote: >>>> http://www.wanderview.com/svn/public/misc/zfs/zfs_zinactive_deadlock.diff >>> >>> The patch is updated in the same location above. >> >> There's a fatal typo in the patch: >> >> - ZFS_OBJ_HOLD_ENTER(zfsvfs, z_id); >> + locked == ZFS_OBJ_HOLD_TRYENTER(zfsvfs, z_id); >> ^^^^ > > Yikes! Thanks for catching this! > > The patch has been updated at the same URL. If anyone has patched > their system please grab the new version. Sorry for the confusion. Argh! The patch was still broken even after this fix. Apparently when I tested my taskqueue solution I forgot to do a make installkernel. For some reason the taskqueue approach deadlocks my server at home under normal conditions. Therefore I have reverted the patch to use the simple return. I still don't think this is the right solution, but I don't have time to completely figure out what is going on right now. Again, sorry for the mess! - Ben