From owner-freebsd-stable@FreeBSD.ORG Thu Jan 17 15:15:28 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3D12F47F; Thu, 17 Jan 2013 15:15:28 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) by mx1.freebsd.org (Postfix) with ESMTP id F17D972A; Thu, 17 Jan 2013 15:15:27 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:14d5:fd99:f891:7575] (unknown [IPv6:2001:7b8:3a7:0:14d5:fd99:f891:7575]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 47EC65C37; Thu, 17 Jan 2013 16:15:21 +0100 (CET) Message-ID: <50F81588.5020106@FreeBSD.org> Date: Thu, 17 Jan 2013 16:15:20 +0100 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20121128 Thunderbird/18.0 MIME-Version: 1.0 To: Kimmo Paasiala Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 References: <50F6D20A.6070306@FreeBSD.org> <20130117001116.GD29437@lor.one-eyed-alien.net> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070106040403010701060104" Cc: Brooks Davis , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 15:15:28 -0000 This is a multi-part message in MIME format. --------------070106040403010701060104 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2013-01-17 14:07, Kimmo Paasiala wrote: > On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: ... >> NetBSD and OpenBSD use different signatures for strnvis(). :( >> pam_ssh_agent_auth assumes that if the system has one it is the OpenBSD >> one but ours is the NetBSD one. The port will need to be patched to use >> the openbsd version like it was doing or to swap the second and third >> arguments when build on newer versions of FreeBSD. > It turns out that security/pam_ssh_agent_auth compiles its own version > of strnvis() when HAVE_STRNVIS is not defined. This in turn results in > an exported dynamic strnvis symbol in the plugin binary. I guess > that's what is breaking things when the plugin binary is loaded on > post r245439 world. > > First thing that comes to my mind for a fix is renaming the local > strnvis() to something else conditionally based on HAVE_STRNVIS. Please try the following patch, which tells configure that HAVE_STRNVIS is always false. I think this is the easiest way, unless we really want the port to use our own strnvis. --------------070106040403010701060104 Content-Type: text/x-diff; name="security__pam_ssh_agent_auth-1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="security__pam_ssh_agent_auth-1.diff" Index: security/pam_ssh_agent_auth/Makefile =================================================================== --- security/pam_ssh_agent_auth/Makefile (revision 310549) +++ security/pam_ssh_agent_auth/Makefile (working copy) @@ -16,6 +16,7 @@ COMMENT= PAM module which permits authentication v USE_BZIP2= yes GNU_CONFIGURE= yes +CONFIGURE_ENV= ac_cv_func_strnvis="no" CONFIGURE_ARGS= --libexecdir=${LOCALBASE}/lib USE_PERL5= yes --------------070106040403010701060104--