From owner-freebsd-current@freebsd.org Sat Apr 9 15:27:33 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B26D3B08FBC for ; Sat, 9 Apr 2016 15:27:33 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 938861DB3 for ; Sat, 9 Apr 2016 15:27:33 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 29FCFB94C; Sat, 9 Apr 2016 11:27:32 -0400 (EDT) From: John Baldwin To: Konstantin Belousov Cc: Wolfgang Zenker , freebsd-current@freebsd.org, freebsd@grem.de Subject: Re: Acer C720 crash at boot Date: Sat, 09 Apr 2016 08:27:27 -0700 Message-ID: <1560530.UPOY1Ni5U9@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20160409142535.GP1741@kib.kiev.ua> References: <20160409121004.GA69051@lyxys.ka.sub.org> <20160409132746.GA69968@lyxys.ka.sub.org> <20160409142535.GP1741@kib.kiev.ua> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 09 Apr 2016 11:27:32 -0400 (EDT) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2016 15:27:33 -0000 On Saturday, April 09, 2016 05:25:35 PM Konstantin Belousov wrote: > On Sat, Apr 09, 2016 at 03:27:46PM +0200, Wolfgang Zenker wrote: > > Done: http://cid2945g797.hs14.hosting.punkt.de/IMG_3762.JPG > > The immediate cause was the change in r297466, but the code that existed > there, did not worked. It looks as a bug in ichiic, set_controller() > use msleep() with timeout too early when compiled into the kernel. Can you try this change: diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c index a556127..23bdb7d 100644 --- a/sys/dev/ichiic/ig4_iic.c +++ b/sys/dev/ichiic/ig4_iic.c @@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint32_t ctl) error = 0; break; } - mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); + if (cold) + DELAY(1000); + else + mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); } return (error); } -- John Baldwin