From owner-cvs-all  Tue Jan  9 14:39:50 2001
Delivered-To: cvs-all@freebsd.org
Received: from feral.com (feral.com [192.67.166.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id BEBB437B401; Tue,  9 Jan 2001 14:39:29 -0800 (PST)
Received: from zeppo.feral.com (IDENT:mjacob@zeppo [192.67.166.71])
	by feral.com (8.9.3/8.9.3) with ESMTP id OAA11131;
	Tue, 9 Jan 2001 14:39:28 -0800
Date: Tue, 9 Jan 2001 14:39:28 -0800 (PST)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: mjacob@feral.com
To: Mike Smith <msmith@FreeBSD.org>
Cc: Matt Jacob <mjacob@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/include bus.h 
In-Reply-To: <200101092237.f09MbvJ01112@mass.osd.bsdi.com>
Message-ID: <Pine.LNX.4.21.0101091439110.28132-100000@zeppo.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG



> > mjacob      2001/01/09 10:17:49 PST
> > 
> >   Modified files:
> >     sys/alpha/include    bus.h 
> >   Log:
> >   The alpha architecture is 64 bits, so bus_addr_t && bus_size_t should really
> >   be 64 bits wide. The largest known current actual physical implementation
> >   is 40 bits, so BUS_SPACE_MAXADDR should reflect this. It also seems to
> >   me that BUS_SPACE_UNRESTRICTED should b ~0UL, not ~0.
> 
> Where a constant is of a known type, one should avoid "UL" in favour of 
> the real type, eg. (~(bus_addr_t)0).  There's too much "long" in the bus 
> code already. 8(
> 
> All IMO.

Sure- it's kinda all the same to me. Knock yerself out!



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message