From owner-svn-src-user@FreeBSD.ORG  Sun Sep 14 22:12:53 2014
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B708EA74;
 Sun, 14 Sep 2014 22:12:53 +0000 (UTC)
Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au
 [211.29.132.246])
 by mx1.freebsd.org (Postfix) with ESMTP id 76EF4D88;
 Sun, 14 Sep 2014 22:12:53 +0000 (UTC)
Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au
 (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133])
 by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 11889425150;
 Mon, 15 Sep 2014 07:54:54 +1000 (EST)
Date: Mon, 15 Sep 2014 07:54:53 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r271574 - user/ngie/add-pjdfstest/contrib/pjdfstest
In-Reply-To: <916E2311-C6BF-423E-A149-3F1853584020@gmail.com>
Message-ID: <20140915074551.B6416@besplex.bde.org>
References: <201409140909.s8E99ncV087445@svn.freebsd.org>
 <20140914200428.P1559@besplex.bde.org>
 <916E2311-C6BF-423E-A149-3F1853584020@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=AOuw8Gd4 c=1 sm=1 tr=0
 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=LRTG6vsd6QsA:10
 a=5LnWPWDnWWAA:10 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8
 a=4FDT9k0moJQWhJTbUroA:9 a=CjuIK1q_8ugA:10
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Garrett Cooper <ngie@freebsd.org>, Bruce Evans <brde@optusnet.com.au>,
 "svn-src-user@freebsd.org" <svn-src-user@freebsd.org>
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Sep 2014 22:12:53 -0000

On Sun, 14 Sep 2014, Garrett Cooper wrote:

>
>> On Sep 14, 2014, at 4:21, Bruce Evans <brde@optusnet.com.au> wrote:
>>
>>> On Sun, 14 Sep 2014, Garrett Cooper wrote:
>>>
>>> Log:
>>> Redo r271374 by using the right typecast for comparing i and ngroups
>>
>> It is still quite broken (more broken than without the cast, since the
>> cast breaks the warning).

>    I completely agree with your concerns. Since this is "contrib" code I wanted to make the smallest set of changes to make things compile, then push for the proper fix upstream.

OK.

>    As an aside, is u_int completely portable; I personally prefer the longer forms of non-fixed width types, e.g. unsigned int, but that's my personal preference.

It is unportable.  It shouldn't be used at all in contrib'ed code, but I
thought that pjd worked here :-).  I think BSD is a BSDism, but using it
is even more natural now than uintN_t is standard (except that matches the
SysVism uint better).

Bruce


Bruce