From owner-freebsd-ports@FreeBSD.ORG Thu Jun 12 15:32:44 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A53A737B401 for ; Thu, 12 Jun 2003 15:32:44 -0700 (PDT) Received: from cultdeadsheep.org (charon.cultdeadsheep.org [80.65.226.72]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06D3743F93 for ; Thu, 12 Jun 2003 15:32:43 -0700 (PDT) (envelope-from sheepkiller@cultdeadsheep.org) Received: (qmail 47370 invoked from network); 12 Jun 2003 22:32:41 -0000 Received: from unknown (HELO lucifer.cultdeadsheep.org) (192.168.0.2) by goofy.cultdeadsheep.org with SMTP; 12 Jun 2003 22:32:41 -0000 Date: Fri, 13 Jun 2003 00:33:00 +0200 From: Clement Laforet To: Paul Chvostek Message-Id: <20030613003300.6a84075b.sheepkiller@cultdeadsheep.org> In-Reply-To: <20030612220827.GB96458@mail.it.ca> References: <20030612185429.GA17904@mail.it.ca> <20030612212009.46193029.sheepkiller@cultdeadsheep.org> <20030612193622.GA68410@mail.it.ca> <20030612215245.32858fe5.sheepkiller@cultdeadsheep.org> <20030612212542.GA96458@mail.it.ca> <20030612234649.2aa1b3cf.sheepkiller@cultdeadsheep.org> <20030612220827.GB96458@mail.it.ca> Organization: tH3 cUlt 0f tH3 d3@d sH33p X-Mailer: Sylpheed version 0.9.1 (GTK+ 1.2.10; i386-portbld-freebsd4.8) X-Face: ._cVVRDn#-2((lnfi^P7CoD4htI$4+#G/G)!w|,}H5yK~%(3-C.JlEYbOjJGFwJkt*7N^%z jYeu[;}]}F"3}l5R'l"X0HbvT^D\Q&%deCo)MayY`);TO Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: ports@freebsd.org Subject: Re: changes to the original source... X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2003 22:32:44 -0000 On Thu, 12 Jun 2003 18:08:27 -0400 Paul Chvostek wrote: > On Thu, Jun 12, 2003 at 11:46:49PM +0200, Clement Laforet wrote: > > > > IMHO, default needed files must have an entry in distinfo. > > Fair enough, and I agree in principle, but are the portlint errors > safe to ignore? Maybe this deserves a new thread, with some details > to gather more readers.... I think so, you know I'm not a ports guru, just a simple maintainer :-) Before you fork this thread, I'll give you my point of view, letting ports/portlint gurus speaking ;-) Usually, I ignore all porlint errors on my Makefile's oddities :) like this one: [root@lucifer|(517)| suphp]# portlint OK: checking /usr/ports/clem/suphp/pkg-descr. OK: checking Makefile. WARN: possible direct use of command "which" found. use ${WHICH} instead. WARN: possible use of absolute pathname "/var/log", in Makefile. WARN: possible use of absolute pathname "/var/log/.", in Makefile. WARN: possible use of absolute pathname "/opt/apache/var/logs...", in Makefile. WARN: possible use of absolute pathname "/usr/bin/php", in Makefile. due to : do-configure: @${ECHO} "Setting logs path" @${REINPLACE_CMD} -e 's,OPT_LOGFILE "/opt/apache/var/logs/suphp_log",OPT_LOGFILE "${LOG_PATH}/suphp_log",' \ ${WRKSRC}/config.h @${ECHO} "Setting php path" @${REINPLACE_CMD} -e 's,OPT_PATH_TO_PHP "/usr/bin/php",OPT_PATH_TO_PHP "${PHP_PATH}",' \ ${WRKSRC}/config.h @${ECHO} "Setting suphp path in mod_suphp" @${REINPLACE_CMD} -e "s,/usr/sbin/suphp,${PREFIX}/sbin/suphp," ${WRKSRC}/apache/mod_suphp.c because I think (maybe badly) that's the best way to avoid multiple useless patches for this port. that's all folks ;) Regards, clem