From owner-freebsd-hackers@FreeBSD.ORG Wed Aug 14 04:12:25 2013 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 35A238D3; Wed, 14 Aug 2013 04:12:25 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BC36B2C30; Wed, 14 Aug 2013 04:12:24 +0000 (UTC) Received: from delphij-macbook.local (c-67-188-85-47.hsd1.ca.comcast.net [67.188.85.47]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 403B4AFB0; Tue, 13 Aug 2013 21:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1376453544; bh=+9IT5qv5z7QxKesaHqLZ+NsCNegMhct/HN8SbRWPibM=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=uziASXo2eIuNPAiAFCr556E7BQ7FlJolzDQEvFCnug3YEglZNYIXbmXjnpb9mPOk/ VX3k+8WFPpcEIYzQZu3XrF0WCIEM7Wa9ce8ZpMP6a4McbVhRkARhidFDAJ/tcjOU0U LI2mntZDAcfcRPPZocXBF4GaZkrJvV13H6CrE5/g= Message-ID: <520B03A7.30406@delphij.net> Date: Tue, 13 Aug 2013 21:12:23 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Richard Yao Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> <8E8C51CCA3474B7A9E2C477D4BCEBB04@multiplay.co.uk> <5207E00F.4000400@gentoo.org> In-Reply-To: <5207E00F.4000400@gentoo.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Eitan Adler , hackers@FreeBSD.org, Steven Hartland X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 04:12:25 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 8/11/13 12:03 PM, Richard Yao wrote: > Is there any possibility that these quirks could be added to the > upcoming 9.2 release? I think so but we need to act fast. > Pools composed of affected disks will suffer from performance > issues until they are reformatted with the correct block size. In > addition, a certain benchmarking site, whose benchmarks are often > fodder for trolls, uses the Intel X25-M in its benchmarks. Adding > the quirk to 9.2 would eliminate an unfair handicap on FreeBSD from > their next set of benchmarks. Actually I'm not 100% sure here: the current FreeBSD ZFS code does not handle stripesize at all, and thus if you create a pool with the patch, they will still be ashift=9. Justin (gibbs@) have a patchset to address this by the way, but since it's not yet in HEAD I wouldn't expect it be incorporated in 9.2... Cheers, -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJSCwOnAAoJEG80Jeu8UPuz4o8H/3D58PVp5lBJ9wpQ/+4YSDAF LdzbhSg5FoRLLgEFKd6q4sbkZglBR5lImWcL/zhGa1KHiq3G6iCstjhfJDQzLnsd tNYnZ9tBCd4AeD/TIFvuLpOJckeXL1TPBSDjXj0xt9rcMCviULma7cr95cswISMD ahK1Io6mVbiGQrCgRmHrUBhnuZfou5nOxPi45l0Lfqq32iJFfgHfmDiCr0mCKkuU sufMeRWS/tjMkl8sVZxP7qncGxbhzVueQeQQ6eJkyv5EQCES6QMZM8xFXfeI//Z4 bDzD37rvt/HRlhPpex0UcpmbYY9dGJJrOALEAPfexMcc++gvLCmYqNfj0ypDj90= =JfHW -----END PGP SIGNATURE-----