From owner-freebsd-current Sun Dec 13 12:48:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA07742 for freebsd-current-outgoing; Sun, 13 Dec 1998 12:48:09 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA07732 for ; Sun, 13 Dec 1998 12:48:07 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id NAA09089; Sun, 13 Dec 1998 13:48:04 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id NAA06177; Sun, 13 Dec 1998 13:48:04 -0700 Date: Sun, 13 Dec 1998 13:48:04 -0700 Message-Id: <199812132048.NAA06177@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Matthew Dillon Cc: freebsd-current@FreeBSD.ORG Subject: Re: minor vipw/pwd_mkdb changes commited In-Reply-To: <199812130203.SAA14359@apollo.backplane.com> References: <199812130203.SAA14359@apollo.backplane.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I've made a few minor fixes to vipw and pwd_mkdb to handle a > master.passwd race condition (note: there are no security issues > with the race). I *think* I fixed this is Auguest already, didn't I? nate 1998/07/16 10:18:30 PDT Modified files: usr.sbin/pw edgroup.c fileupd.c pw.c Log: Fix race condition in pw caused by multiple instances of pwd_mkdb being run at the same time. Notes: The fileupdate function is still somewhat broken. Instead of returning a failure code if it can't modify the original file it renames the .new file and continues as though nothing is wrong. This will cause the lock on the original file to be lost and could lead to a similar race condition. I left that portion of the code alone since I feel that the maintainer of the code would have a better concept of how he wants to handle errors in that function than I do. PR: bin/6787 Submitted by: Craig Spannring If not, will these changes conflict with the above changes? Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message