From owner-svn-src-user@FreeBSD.ORG Fri Apr 30 03:53:00 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8D86A1065675; Fri, 30 Apr 2010 03:53:00 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 506138FC18; Fri, 30 Apr 2010 03:53:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o3U3nrGU015049; Thu, 29 Apr 2010 21:49:54 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 29 Apr 2010 21:50:06 -0600 (MDT) Message-Id: <20100429.215006.342007108973685078.imp@bsdimp.com> To: jmallett@freebsd.org From: "M. Warner Losh" In-Reply-To: <201004300314.o3U3Eluq041543@svn.freebsd.org> References: <201004300314.o3U3Eluq041543@svn.freebsd.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r207417 - user/jmallett/octeon/sys/mips/mips X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2010 03:53:00 -0000 In message: <201004300314.o3U3Eluq041543@svn.freebsd.org> Juli Mallett writes: : That's just the uart code, which seems to use its own bus space : anyway. The UART code needs to have its own space. The uart*.c code is mostly setup to read bytes from the uart device. We use bus space to spread out the bytes (which uart could do itself, but we tell it not to), as well as insure that the 64-bit registers are accessed as 64-bit registers. This is important for the Octeon take on a 16550 since byte reads/writes cause problems, at least on some members of the family. The bus space code bridges these two worlds. It also solves the 'big endian' issues that the atheros code still has... Warner