From owner-freebsd-bugs@freebsd.org Sat Nov 16 03:53:29 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A49C1B8E6D for ; Sat, 16 Nov 2019 03:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47FLt05TN6z4F6c for ; Sat, 16 Nov 2019 03:53:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B6AC01B8E6C; Sat, 16 Nov 2019 03:53:28 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B65501B8E6B for ; Sat, 16 Nov 2019 03:53:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47FLt02LRZz4F60 for ; Sat, 16 Nov 2019 03:53:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 13732237FC for ; Sat, 16 Nov 2019 03:53:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id xAG3rRBl016298 for ; Sat, 16 Nov 2019 03:53:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id xAG3rRJl016297 for bugs@FreeBSD.org; Sat, 16 Nov 2019 03:53:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 234793] Failed unknown for $USER in sshd logs even if I got authenticated Date: Sat, 16 Nov 2019 03:53:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: henry.hu.sh@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2019 03:53:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234793 Henry Hu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henry.hu.sh@gmail.com --- Comment #23 from Henry Hu --- This bug was introduced in https://reviews.freebsd.org/rS339216. In this commit, a wrapper was added for login_getpwclass. The line in the dispatch table says: {MONITOR_REQ_GETPWCLASS, MON_AUTH, mm_answer_login_getpwclass}, Because the flag is MON_AUTH, which includes MON_AUTHDECIDE, which means #define MON_AUTHDECIDE 0x0008 /* Decides Authentication */ So the result of this wrapped call is recorded through auth_log() at line 3= 39 of monitor.c: https://svnweb.freebsd.org/base/head/crypto/openssh/monitor.c?view=3Dmarkup= #l343 mm_answer_login_getpwclass only retrieves some information from logincap, s= o it does not decide the authentication result, and it always returns 0. Thus, I think that the flag is incorrectly set. I think that the correct value shou= ld be MON_ISAUTH. --=20 You are receiving this mail because: You are the assignee for the bug.=