From owner-cvs-src@FreeBSD.ORG Tue Jan 31 15:01:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B89516A428; Tue, 31 Jan 2006 15:01:58 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABDEE43D72; Tue, 31 Jan 2006 15:01:52 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k0VF1pmG019132; Tue, 31 Jan 2006 08:01:51 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43DF7BE5.4050609@samsco.org> Date: Tue, 31 Jan 2006 08:01:57 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Marius Strobl References: <200601311448.k0VEmwVF043100@repoman.freebsd.org> In-Reply-To: <200601311448.k0VEmwVF043100@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/le am7990.c am79900.c am79900reg.h am79900var.h am7990reg.h am7990var.h if_le_ledma.c if_le_pci.c lance.c lancereg.h lancevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 15:01:58 -0000 Marius Strobl wrote: > marius 2006-01-31 14:48:58 UTC > > FreeBSD src repository > > Added files: > sys/dev/le am7990.c am79900.c am79900reg.h > am79900var.h am7990reg.h am7990var.h > if_le_ledma.c if_le_pci.c lance.c > lancereg.h lancevar.h > Log: > Add le(4), a driver for AMD Am7900 LANCE and Am79C9xx PCnet NICs ported > from NetBSD. This driver actually can replace lnc(4). Advantages over > lnc(4) are: > - Cleaner and more flexible regarding MD needs. > - Endian-clean and MPSAFE. > - Supports ALTQ, VLAN_MTU, ifmedia. > - Uses 32bit DMA for the PCI variants. > > This commit includes front-ends for the dma(4) pseudo-bus found on SBus- > based sparc64 machines (thus supports the on-board LANCE in Sun Ultra 1) > and PCI. In order to actually replace lnc(4), the front-ends for ISA and > the PC98 CBUS would have to be added but for which I don't have hardware > to test. > > Reviewed and some improvements by: yongari > Tested on: i386, sparc64 > Excellent job! One question, though. I believe that VMWare emulates Lance hardware. If your new le driver works on that, then I see no reason to not disable the lnc driver and enable the le driver by default. Scott