From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 17 18:40:43 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25C2D16A546 for ; Tue, 17 Feb 2004 18:40:43 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D210843D76 for ; Tue, 17 Feb 2004 18:40:30 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i1I2eUbv028645 for ; Tue, 17 Feb 2004 18:40:30 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1I2eURk028643; Tue, 17 Feb 2004 18:40:30 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 17 Feb 2004 18:40:30 -0800 (PST) Resent-Message-Id: <200402180240.i1I2eURk028643@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Roselyn Lee Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F4F516A4CE for ; Tue, 17 Feb 2004 18:39:09 -0800 (PST) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C5D743D1D for ; Tue, 17 Feb 2004 18:39:09 -0800 (PST) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i1I2d972008482 for ; Tue, 17 Feb 2004 18:39:09 -0800 (PST) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.10/8.12.10/Submit) id i1I2d986008465; Tue, 17 Feb 2004 18:39:09 -0800 (PST) (envelope-from nobody) Message-Id: <200402180239.i1I2d986008465@www.freebsd.org> Date: Tue, 17 Feb 2004 18:39:09 -0800 (PST) From: Roselyn Lee To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/62989: ether_input computes incorrect m_pkthdr.len when mbufs are chained X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2004 02:40:44 -0000 >Number: 62989 >Category: kern >Synopsis: ether_input computes incorrect m_pkthdr.len when mbufs are chained >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Feb 17 18:40:30 PST 2004 >Closed-Date: >Last-Modified: >Originator: Roselyn Lee >Release: 4.8 >Organization: Vernier Networks >Environment: 4.8-RELEASE FreeBSD >Description: m_pkthdr.len that is computed by ether_input() incorrectly assumes m_len is the length of the entire packet. For example, the sis0 driver could return a list of mbufs to hold an incoming packet when the system is out of clusters. >How-To-Repeat: >Fix: void ether_input(struct ifnet *ifp, struct ether_header *eh, struct mbuf *m) { struct ether_header save_eh; if (eh == NULL) { if (m->m_len < sizeof(struct ether_header)) { /* XXX error in the caller. */ m_freem(m); return; } m->m_pkthdr.rcvif = ifp; eh = mtod(m, struct ether_header *); m->m_data += sizeof(struct ether_header); m->m_len -= sizeof(struct ether_header); - m->m_pkthdr.len = m->m_len; + /* + * Adjust m_pkthdr.len by the same amount - + * do not assume m_pkthdr.len == m_len + */ + m->m_pkthdr.len -= sizeof (struct ether_header); } >Release-Note: >Audit-Trail: >Unformatted: