Date: Tue, 1 Aug 2023 02:31:39 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: "Tobias C. Berner" <tcberner@freebsd.org>, Antoine Brodin <antoine@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7bb64b89d0e5 - main - framework: add Mk/Uses/pycryptography Message-ID: <CAMHz58S2ALF-42p9a6GGzyVVmNNC9rZaai5fOFOTWSCFBq=dog@mail.gmail.com> In-Reply-To: <CAOshKte4QVfiRuqrJMfJeF2Qc%2BuLhJOo2v=CLUVdceS=SiSapA@mail.gmail.com> References: <202307220748.36M7mgIt016872@gitrepo.freebsd.org> <CAALwa8ntOrr3TB7WALhWMrj59_f2=THeuMzQDJt29hHAVpQZkw@mail.gmail.com> <CAOshKte4QVfiRuqrJMfJeF2Qc%2BuLhJOo2v=CLUVdceS=SiSapA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004d910b0601cca605
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hello,
How about USE_PYTHON=3D{cryptography_build,cryptography,cryptography_test}?
USE_PYTHON=3Dcryptography is the runtime dependency because it is mostly us=
ed
in RUN_DEPENDS.
For the current ports tree, I get the following result via "git grep
pycryptography":
89 USES=3Dpycryptography:run
5 USES=3Dpycryptography:test
2 USES=3Dpycryptography:run,test
1 USES=3Dpycryptography:build,run
0 USES=3Dpycryptography
Regards,
sunpoet
On Mon, Jul 24, 2023 at 10:54=E2=80=AFPM Tobias C. Berner <tcberner@freebsd=
.org>
wrote:
> Moin moin
>
> It seemed an easier way to stop-gap fix this issue separately. But
> you're probably right, that python.mk would be the preferred location
> to do so.
>
> I can move it there.
>
>
> mfg Tobias
>
> On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <antoine@freebsd.org> wrote:
> >
> > On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner <tcberner@free=
bsd.org>
> wrote:
> > >
> > > The branch main has been updated by tcberner:
> > >
> > > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f8341269=
ffbad279ebf
> > >
> > > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
> > > Author: Tobias C. Berner <tcberner@FreeBSD.org>
> > > AuthorDate: 2023-07-22 06:16:46 +0000
> > > Commit: Tobias C. Berner <tcberner@FreeBSD.org>
> > > CommitDate: 2023-07-22 07:46:38 +0000
> > >
> > > framework: add Mk/Uses/pycryptography
> > >
> > > With the added new DEFAULT_VERSION
> "PYCRYPTOGRAHY_DEFAULT=3Drust|legacy"
> > > it is important to transparently depend on the right one.
> > >
> > > This is the job of this new uses.
> > >
> > > So instead of manually adding dependency lines like
> > >
> > >
> RUN_DEPENDS=3D${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptogr=
aphy@
> ${PY_FLAVOR}
> > >
> > > this should now be
> > >
> > > USES=3Dpycryptography:run
> > >
> > > Supported arguments: <none>,build,run,test
> > > If no argument is given, it defaults to 'build,run'.
> > >
> > > A future commit will update to security/py-cryptography will
> introduce a
> > > rust dependency.
> > >
> > > PR: 254853
> >
> > Hi,
> >
> > Why isn't it a USE_PYTHON=3D pycryptography?
> >
> > Antoine
>
--0000000000004d910b0601cca605
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>Hello,</div><div><br></div><div>How about USE_PYTHON=
=3D{cryptography_build,cryptography,cryptography_test}?</div><div>USE_PYTHO=
N=3Dcryptography is the runtime dependency because it is mostly used in RUN=
_DEPENDS.</div><div><br></div><div>For the current ports tree, I get the fo=
llowing result via "git grep pycryptography":</div><div>89 USES=
=3Dpycryptography:run</div><div>=C2=A05 USES=3Dpycryptography:test</div><di=
v>=C2=A02 USES=3Dpycryptography:run,test</div><div>=C2=A01 USES=3Dpycryptog=
raphy:build,run</div><div>=C2=A00 USES=3Dpycryptography</div><div><br></div=
><div>Regards,</div><div>sunpoet</div><div><br></div><div>On Mon, Jul 24, 2=
023 at 10:54=E2=80=AFPM Tobias C. Berner <<a href=3D"mailto:tcberner@fre=
ebsd.org">tcberner@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_=
quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">Moin moin<br>
<br>
It seemed an easier way to stop-gap fix this issue separately. But<br>
you're probably right, that <a href=3D"http://python.mk" rel=3D"norefer=
rer" target=3D"_blank">python.mk</a> would be the preferred location<br>
to do so.<br>
<br>
I can move it there.<br>
<br>
<br>
mfg Tobias<br>
<br>
On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <<a href=3D"mailto:antoine@=
freebsd.org" target=3D"_blank">antoine@freebsd.org</a>> wrote:<br>
><br>
> On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner <<a href=
=3D"mailto:tcberner@freebsd.org" target=3D"_blank">tcberner@freebsd.org</a>=
> wrote:<br>
> ><br>
> > The branch main has been updated by tcberner:<br>
> ><br>
> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D7bb64=
b89d0e5ec8d77b28f8341269ffbad279ebf" rel=3D"noreferrer" target=3D"_blank">h=
ttps://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f8341269ffb=
ad279ebf</a><br>
> ><br>
> > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf<br>
> > Author:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.=
org><br>
> > AuthorDate: 2023-07-22 06:16:46 +0000<br>
> > Commit:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.=
org><br>
> > CommitDate: 2023-07-22 07:46:38 +0000<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0framework: add Mk/Uses/pycryptography<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0With the added new DEFAULT_VERSION "PYCRY=
PTOGRAHY_DEFAULT=3Drust|legacy"<br>
> >=C2=A0 =C2=A0 =C2=A0it is important to transparently depend on the=
right one.<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0This is the job of this new uses.<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0So instead of manually adding dependency lines=
like<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RUN_DEPENDS=3D${PY=
THON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@${PY_FLAVOR}<=
br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0this should now be<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0USES=3Dpycryptogra=
phy:run<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0Supported arguments: <none>,build,run,te=
st<br>
> >=C2=A0 =C2=A0 =C2=A0If no argument is given, it defaults to 'b=
uild,run'.<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0A future commit will update to security/py-cry=
ptography will introduce a<br>
> >=C2=A0 =C2=A0 =C2=A0rust dependency.<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0254853<br>
><br>
> Hi,<br>
><br>
> Why isn't it a USE_PYTHON=3D pycryptography?<br>
><br>
> Antoine<br>
</blockquote></div></div>
--0000000000004d910b0601cca605--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58S2ALF-42p9a6GGzyVVmNNC9rZaai5fOFOTWSCFBq=dog>