From owner-freebsd-scsi@FreeBSD.ORG Mon Jun 2 16:46:12 2014 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5FED5EAF for ; Mon, 2 Jun 2014 16:46:12 +0000 (UTC) Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com [209.85.213.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2ACBE2B0B for ; Mon, 2 Jun 2014 16:46:11 +0000 (UTC) Received: by mail-ig0-f177.google.com with SMTP id l13so3627403iga.10 for ; Mon, 02 Jun 2014 09:46:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:subject:message-id:date :to:mime-version; bh=tBocR1gwIgqwC5idtN1t9k+wqualinY1HeuP9ZtkHvI=; b=fe7YDKEFdIExVYBJYmBaVumssHoKqtrdOR6OHFYlOIr8/A6ccwTRUWYte9TBS/gf2n Ms4lFlCUwX3HTmBxCJMIy3g6qoVDrIqjheg3ddSUJjEwyiVlZ17g7aymbNFp/Aht9uD0 lflC91gMcxsb8z6Qsw7w1hX+BOt0kvpSGXV4esf/jfdzVBLdTJq58gGQ0JndVIepsSY8 BkYLbvzOpBb01KIbsbBAGKQ84OEdRteb1I1xz1mEHCLMQnqLjM6a0IQHOd1+kGUAp+uv pWx0dqG/4Y9/s75h9wrq0bLT1GVTblbHzoipB4741cxhsklLLdSgtk5TWFUwAFmh/otA cnOQ== X-Gm-Message-State: ALoCoQmQN8m6YRtZscAEbYYPDt/M2SKS3enJjWVxmB3hDRYtcujzIWIZ4JyTIUbkrLqadJE1Qa3B X-Received: by 10.43.75.2 with SMTP id yy2mr37096360icb.54.1401727565311; Mon, 02 Jun 2014 09:46:05 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id g3sm17022086igo.11.2014.06.02.09.46.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 09:46:04 -0700 (PDT) Sender: Warner Losh From: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_73DD6227-4E02-4592-98BE-AF91A6D19F95"; protocol="application/pgp-signature"; micalg=pgp-sha512 Subject: Review needed Message-Id: Date: Mon, 2 Jun 2014 10:46:11 -0600 To: freebsd-scsi@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) X-Mailer: Apple Mail (2.1878.2) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 16:46:12 -0000 --Apple-Mail=_73DD6227-4E02-4592-98BE-AF91A6D19F95 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Greetings, The code that combines adjacent ranges for BIO_DELETEs to optimize trims to the device assumes the list is sorted. Don't apply the optimization of not sorting the queue when we have SSDs to the delete_queue, since it causes more discard traffic to the drive. While one could argue that the higher levels should coalesce the trims, that's not done today, so some optimization at this level is needed. Diffs and a (hopefully) cool review tool: https://phabric.freebsd.org/D142 Comments? Warner --Apple-Mail=_73DD6227-4E02-4592-98BE-AF91A6D19F95 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTjKpTAAoJEGwc0Sh9sBEA8ggQAJSOn9MsyR+di1XKAIUnK62x jnaSvkBD3Fq1Zd3aBeHgtarVE06eSLeufun/hgmrzbMHOENT+DQPckoXlw7rte7K eYrKusn5HPrxVEJLPVgtHv88960cso/qnttgxCuKtj+vCxg9X6+Cieb8rRYz3Cos M6L6c0wyy+4/hoxODvGU7hEdXrzWJiGCbb2Xg0Pzm/C2ExxP98dliXOhbNHbKNel iZdSPHNgw83NSBtMxrp/tmNBf2SnS3JiqsigJ7A6XB1ajs/K/Wh5l0ATPx+JKsG1 Y0O2m7ylcNOPD22vZq4LC6RjIpGXsDzjeAkQTWXuZzfHPQTVsvpclRViCsUokCnJ cnS31dtv8dqPSLBPfd1crklBofIOs7wlk2HCLxZcVKWiQzWldP9JAyWL8BApzYiU /f8hxielJZmIQbLjleWmv1YtbirfJNfCtIzcZQiiMidACqoXdplWMJOKS7Rvjek/ r9zxd8Bi/e7ORD3uAthVJc5oiO4+N/p4SbARxLiFy756UF2yOswFzamOExKD+d7M 8QuXxWQVc1wI2i2E6Xoa9/eUUMW9IEETU0KAEJRD6m/eNJHIH0ANTPncRtJQ9vBb hCvjcTdXJblr8fxrKIzo5rr9t6+rDUA10SXMqBXqEh6tujphKm229RWXwgeMI9fL q17MTB2gsHj63bbHN/eh =odDi -----END PGP SIGNATURE----- --Apple-Mail=_73DD6227-4E02-4592-98BE-AF91A6D19F95--