From owner-svn-src-user@FreeBSD.ORG  Tue Jan  5 18:07:20 2010
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 95175106566B;
	Tue,  5 Jan 2010 18:07:20 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: from mail-ew0-f226.google.com (mail-ew0-f226.google.com
	[209.85.219.226])
	by mx1.freebsd.org (Postfix) with ESMTP id C10A98FC16;
	Tue,  5 Jan 2010 18:07:19 +0000 (UTC)
Received: by ewy26 with SMTP id 26so14530064ewy.3
	for <multiple recipients>; Tue, 05 Jan 2010 10:07:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:received:in-reply-to
	:references:from:date:x-google-sender-auth:message-id:subject:to:cc
	:content-type; bh=KnL+q9p+pBJzA2ocCU8cPUZuDkmGc4klzbzxuopAUws=;
	b=qOWHl+s43Jves/fWl8w2i0D9NAkFL5eDEn0PIperoxfFLb1tfoPjOQWBGiI6rIMh70
	wnpB3Gxu46mZB4f09BpWHY4VimPcX1bthAuBSznW7D2qPX9y6WKXqo2EpW9WcRMCdIvL
	WrBH7cZT1mYTj0yJzCY5KtTymU4r/GAhRvcLo=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	b=k97wPrmTDC7+OwZjXq+xWucGNmitFymlebZJSGrQ4b6KVhu8m8ykn1U6sMC5/Q93SV
	dymcuCtIRNhHl+KLy7QGB5Jc6JLNn/E6fJOz8I9DKgzzOAPhx/qw9glvQCy8oLj1CxL6
	WH+xkCqwWeDDsJRD64eN9oMyQ9pl6d/HkshZE=
MIME-Version: 1.0
Sender: ermal.luci@gmail.com
Received: by 10.216.89.206 with SMTP id c56mr1022139wef.123.1262714831208; 
	Tue, 05 Jan 2010 10:07:11 -0800 (PST)
In-Reply-To: <201001041658.o04GwFfG023749@svn.freebsd.org>
References: <201001041658.o04GwFfG023749@svn.freebsd.org>
From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org>
Date: Tue, 5 Jan 2010 19:06:51 +0100
X-Google-Sender-Auth: 35e96daa00536959
Message-ID: <9a542da31001051006r61af058eg715c29ef0d3d2020@mail.gmail.com>
To: Luigi Rizzo <luigi@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: Re: svn commit: r201517 - in user/luigi/ipfw3-head/sys/netinet: . 
	ipfw
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2010 18:07:20 -0000

On Mon, Jan 4, 2010 at 5:58 PM, Luigi Rizzo <luigi@freebsd.org> wrote:

> Author: luigi
> Date: Mon Jan  4 16:58:15 2010
> New Revision: 201517
> URL: http://svn.freebsd.org/changeset/base/201517
>
> Log:
>  divert has no specific API so we don't really need an ip_divert.h
>
>
>  DECLARE_MODULE(ipdivert, ipdivertmod, SI_SUB_PROTO_IFATTACHDOMAIN,
> SI_ORDER_ANY);
> -MODULE_DEPEND(dummynet, ipfw, 2, 2, 2);
> +MODULE_DEPEND(ipdivert, ipfw, 2, 2, 2);
>  MODULE_VERSION(ipdivert, 1);
>

I would suggest to remove the dependency altogether  since divert(4) does
not really depend on ipfw(4). Furthermore, the newest pf(4) can work
together with divert(4) so the it will have more than one consumer in the
tree.

-- 
Ermal