Date: Tue, 5 Jan 2010 19:06:51 +0100 From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> To: Luigi Rizzo <luigi@freebsd.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r201517 - in user/luigi/ipfw3-head/sys/netinet: . ipfw Message-ID: <9a542da31001051006r61af058eg715c29ef0d3d2020@mail.gmail.com> In-Reply-To: <201001041658.o04GwFfG023749@svn.freebsd.org> References: <201001041658.o04GwFfG023749@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 4, 2010 at 5:58 PM, Luigi Rizzo <luigi@freebsd.org> wrote: > Author: luigi > Date: Mon Jan 4 16:58:15 2010 > New Revision: 201517 > URL: http://svn.freebsd.org/changeset/base/201517 > > Log: > divert has no specific API so we don't really need an ip_divert.h > > > DECLARE_MODULE(ipdivert, ipdivertmod, SI_SUB_PROTO_IFATTACHDOMAIN, > SI_ORDER_ANY); > -MODULE_DEPEND(dummynet, ipfw, 2, 2, 2); > +MODULE_DEPEND(ipdivert, ipfw, 2, 2, 2); > MODULE_VERSION(ipdivert, 1); > I would suggest to remove the dependency altogether since divert(4) does not really depend on ipfw(4). Furthermore, the newest pf(4) can work together with divert(4) so the it will have more than one consumer in the tree. -- Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9a542da31001051006r61af058eg715c29ef0d3d2020>