From owner-cvs-all Wed Aug 30 6:25:10 2000 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 20E1037B424; Wed, 30 Aug 2000 06:25:05 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.9.3/8.9.3) with SMTP id JAA11172; Wed, 30 Aug 2000 09:25:04 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 30 Aug 2000 09:25:04 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/linux/linprocfs linprocfs_vnops.c In-Reply-To: <200008301323.GAA07228@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG So I'm not clear why my clean build of GENERIC didn't pick this up. Do the modules (or linprocfs, specifically) use the system /usr/include/sys, or something? I also noticed that after making some changes, the dependencies weren't always picked up right. Anyhow, the compile should be fixed, and as mentioned in the commit message, I'll apply a few further changes to linprocfs later today. Thanks, Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services On Wed, 30 Aug 2000, Robert Watson wrote: > rwatson 2000/08/30 06:23:19 PDT > > Modified files: > sys/i386/linux/linprocfs linprocfs_vnops.c > Log: > o Update linprocfs to include similar changes as those in procfs, fixing > the build (oops!): replace calls to p_trespass() and PRISON_CHECK() > with p_can(..., {P_CAN_SEE, P_CAN_DEBUG}, NULL) > o Remove volatile usage from procfs_readdir() to remove warnings > o Apply bp's CREATE fix to linprocfs, causing EROFS to be returned on > CREATE calls to procfs_lookup() > o Some further synchronization still needs to occur: only existing > access checks were replaced, to fix the build--the new ones were not > added. I'll do this later today, this is a "fix the build quickly" > commit. This means that, in the interim, some information leakage > can still occur via linprocfs when using jail or kern.ps_showallprocs > > Submitted by: knu > Approved by: des > Obtained from: TrustedBSD Project > > Revision Changes Path > 1.4 +10 -9 src/sys/i386/linux/linprocfs/linprocfs_vnops.c > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message