From owner-freebsd-current@FreeBSD.ORG Fri Dec 9 11:36:50 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6104F16A425 for ; Fri, 9 Dec 2005 11:36:50 +0000 (GMT) (envelope-from ai@bmc.brk.ru) Received: from stalker.bmc.brk.ru (stalker.bmc.brk.ru [217.150.59.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 968E643D67 for ; Fri, 9 Dec 2005 11:36:43 +0000 (GMT) (envelope-from ai@bmc.brk.ru) Date: Fri, 9 Dec 2005 14:36:34 +0300 From: Artemiev Igor To: freebsd-current@freebsd.org Message-Id: <20051209143634.09bc2d90.ai@bmc.brk.ru> In-Reply-To: <200512080951.52387.jhb@freebsd.org> References: <20051206093020.691e1483.ai@bmc.brk.ru> <200512070816.46165.jhb@freebsd.org> <20051208090835.471a5584.ai@bmc.brk.ru> <200512080951.52387.jhb@freebsd.org> Organization: Bryansk Medical Center X-Mailer: Sylpheed version 2.0.0beta4 (GTK+ 2.6.8; i386-portbld-freebsd5.4) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] nForce2 SMBus support X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2005 11:36:50 -0000 On Thu, 8 Dec 2005 09:51:51 -0500 John Baldwin wrote: > > I simply do not see any way to do it with current implementation of > > ampdm(and also viapm, etc) & smbus, without modifying the smb- > > >smbus->smbus driver interface. I may be wrong, but as far as I > > >know, currently it's one > > smb for one driver (smbus_* limitation) > > Hmm, it doesn't specify the child device, just the parent. *sigh* > That's lame. You don't have to call it amdpmsub0 btw, you could just > call it amdpm1 if you wanted and have amdpm1 a child of amdpm0. All > that would need to change for that is the NF2_SUBDEV string and the > DRIVER_MODULE line (it would be DRIVER_MODULE(amdpm, amdpm, ...)). > This has the added advantage that you don't have to patch smbus.c. I remade it as you described - can't understand, why I didn't think about it myself -- iprefetch ai