From owner-freebsd-ports@freebsd.org Mon Sep 25 05:08:30 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72C51E09A11; Mon, 25 Sep 2017 05:08:30 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3005D6E2D2; Mon, 25 Sep 2017 05:08:30 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-io0-x234.google.com with SMTP id i197so8669839ioe.9; Sun, 24 Sep 2017 22:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dK+70F4GJ92eOekfij74d+lS7+/+lv1iESp4WS0UEXQ=; b=Oo1jVX6HoBeb/4k+LrHZny7pTHNb2FOGtJAQq1kCi50Vuh+AwVWLLS6MzbZk/oe9p5 5hc9E87wLZQZpkhioNrJ1Xcv2KACHN8UMawnD/Fp2lCUMeS0mXp4krHBaHXPcxmZ97xU GtJuDKUFMGQEhmEOFx7a/FSOBd2DAzWp8qCcs5jaGYnmRCjKjkOJg/aSSCOLTWoNv5E1 icxnBjDYTM+5d2ehmfsQBJwSlYxuPuw5NtDoNdeWLioEFHkMvpGRfkqoHOCdiGkxbNvn vkcooH9Hf3VoKNy9VDsiH9vsaekzW57NwxlLRxIenn6yHNYR41kKyuRGnT4TAQDd4duJ aTfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dK+70F4GJ92eOekfij74d+lS7+/+lv1iESp4WS0UEXQ=; b=hcCQEDzaVpFFIZ9cILIaJqhoaVKHhJ5iIqnV+4948ftbP9/sya4leWeAwe1d/bcf0y T90DGpihDxPsq+bIr3qYK24QckNqgB9DGZhuFXy+72HHkNgecHZk3IuswX9aT6r43tBq pDyeLEsrF/+DJPwWVOYQbKud9vIw5x1uQ5vEC+KMaM004DjWsPmQs3514z0kwdAJ6+gv malrNWOZQZwCJxTSA63gq50ixkQJxigA3DvhlPckQRt7zitrrRA56FqM6Nb3z8cvdQIT 4islE4V9zfSe/arFx6FOguz+MHdfAZf22dTdQpjGAxaqcwnaIN+D5RD9Oy3w0/RdrBAh 0qSA== X-Gm-Message-State: AHPjjUjvr7nthobi8Lzaj7tymS49zrXN1W3XAwWx86naR+4bLIjAr68Y FpOWv1oeiekt+6ZFEUDE7KnNSQFI X-Google-Smtp-Source: AOwi7QDwm2W6W5XhWH3J4++B8gasqUHyKBg0Y+U+ZUPD92ZomIqCgTl4eeGRUn7O1P/VCXM8OBywlg== X-Received: by 10.107.24.133 with SMTP id 127mr8546671ioy.115.1506316109259; Sun, 24 Sep 2017 22:08:29 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:9442:79f1:c7c:81a3? (2001-44b8-31ae-7b01-9442-79f1-0c7c-81a3.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:9442:79f1:c7c:81a3]) by smtp.gmail.com with ESMTPSA id v5sm2477149iog.43.2017.09.24.22.08.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Sep 2017 22:08:28 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: Porters Handbook section 4.4 To: Russell Haley , freebsd-ports@freebsd.org, doc@freebsd.org References: From: Kubilay Kocak Message-ID: <8a3e663a-d94f-0ef7-bbc7-8ebaa111f6dd@FreeBSD.org> Date: Mon, 25 Sep 2017 15:02:12 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 05:08:30 -0000 On 9/25/17 2:08 PM, Russell Haley wrote: > Hi, > > Section 4.3 of the porters handbook talks about making modifications > to a private copy of a tarball and recording the steps. > > Section 4.4 talks about changing directories into the affected ports > dir and running make makepatch to generate patch files. > > I am unsure how the makepatch target is supposed to find my private > directory. Since I was confused, I created patches, added them to the > port, ran make, then ran make makepatch and the system re-generated > new "makepatch" patches. Quite a number of new users have raised the same question on IRC. > So, my question is thus: > > To me, section 4.4 seems vague about where changes should be made, > which is compounded by the information in section 4.3. Can the > makepatch target ask for and find a private directory, or should the > handbook be clarified to state that the changes should be made to the > 'work' folder? If the later is true, I assume there is some proper > workflow to keep changes from being destroyed while testing? The handbook section needs to be updated to be less ambiguous with regard to where things should be done. I'd be happy to provide a docs committer with verbiage if they can help with formatting/commit. > If there is a section in the handbook clarifying this, please just say > so and I will go find it. > > Thanks! > Russ ./koobs