From owner-freebsd-stable@FreeBSD.ORG Wed Jan 24 01:46:58 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BDE0516A407 for ; Wed, 24 Jan 2007 01:46:58 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.191]) by mx1.freebsd.org (Postfix) with ESMTP id 5863013C461 for ; Wed, 24 Jan 2007 01:46:58 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nf-out-0910.google.com with SMTP id m19so426786nfc for ; Tue, 23 Jan 2007 17:46:57 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BfnBouBmKDf+hwb1WtcIbSphbnr4AsHUuXtragpKMltcXxGLjlKOHaVwTJxR1mwniKPsx8rfsG2kSGC1GxIknp+UHjlI12RPuQ3kvtpH47A9muFy0loh7YG8KQJsdK2NN+Amj1CXMJUHa+1u+1hvV+HT+T26yljVQGzFUiE2y+w= Received: by 10.82.118.2 with SMTP id q2mr46409buc.1169603216749; Tue, 23 Jan 2007 17:46:56 -0800 (PST) Received: by 10.82.127.12 with HTTP; Tue, 23 Jan 2007 17:46:51 -0800 (PST) Message-ID: <2a41acea0701231746p5706bda4vb54cb0c83b809e1b@mail.gmail.com> Date: Tue, 23 Jan 2007 17:46:51 -0800 From: "Jack Vogel" To: "Jack Vogel" , freebsd-current@freebsd.org, freebsd-stable@freebsd.org In-Reply-To: <20070123235004.GF1504@cryptomonkeys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2a41acea0701171258k16b4c6ebuf1d4794b89d0749b@mail.gmail.com> <20070120065321.DB61216A405@hub.freebsd.org> <2a41acea0701201435g6f960b40r3cf0552d87ab2bfd@mail.gmail.com> <20070122083506.GW4485@FreeBSD.org> <2a41acea0701221030x52dd8821pd858ae7e6740ce92@mail.gmail.com> <2a41acea0701221034j42fed2a9g3934ef187e3964ca@mail.gmail.com> <20070123235004.GF1504@cryptomonkeys.com> Cc: Subject: Re: Lenovo X60 em workaround X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2007 01:46:58 -0000 On 1/23/07, Louis Kowolowski wrote: > On Mon, Jan 22, 2007 at 10:34:48AM -0800, Jack Vogel wrote: > > On 1/22/07, Jack Vogel wrote: > > >On 1/22/07, Gleb Smirnoff wrote: > > >> Jack, > > >> > > >> On Sat, Jan 20, 2007 at 02:35:17PM -0800, Jack Vogel wrote: > > >> J> >> Since this was just seen, and the patch below validated as working > > >I > > >> J> >wanted > > >> J> >> to send general email to capture this: > > >> J> >> > > >> J> >> The Lenovo X60 can have issues with long ping times, this is a > > >KNOWN > > >> J> >> hardware problem, and Intel is working with IBM/Lenovo, a final > > >'fix' has > > >> J> >> not been decided on yet. Nevertheless, the patch below will work, > > >but > > >> J> >> I do not want to check it in as its still temporary. > > >> J> >> > > >> J> >> Address questions to me, > > >> J> > > > >> J> >Okay, I have a question. Could you elaborate on just what the > > >problem is? > > >> J> >(I mean, since it's KNOWN and all...) I'm just having a hard time > > >figuring > > >> J> >out what problem could possibly be fixed by setting the RX interrupt > > >> J> >delay timer to a non-zero value (especially since elsewhere in the > > >em(4) > > >> J> >source it says that doing so is a Bad Thing (tm)). > > >> J> > > >> J> saying its known to be a problem doesnt mean its cause is known :) > > >> J> They discovered that setting this eliminated the problem, but we > > >> J> immediately pointed out that this is, as you pointed out, a Bad > > >> J> Thing on other hardware, so the investigation continues, there is > > >> J> always a communication lag on these kind of things, so I dont know > > >> J> if it has been resolved yet or not. > > >> J> > > >> J> I just dont think this patch will become the final way to solve this, > > >> J> but we shall see :) > > >> > > >> Good to know that there is progress on this. Thanks! I will try the patch > > >> on my Lenovo T60 notebook, where the problem is also present. AFAIK, it > > >> is present on any Lenovo notebook with 82573 NIC. > > >> > > >> Can you please acknowledge that another bug with Lenovo + em(4) is > > >known? I > > >> mean the problem, that em(4) isn't initialized properly on kernel boot, > > >if > > >> the link is down. I have already reported this to you, and you said that > > >> I probably have bad hardware. Since that time, I've found several similar > > >> reports about Lenovo notebooks and em(4) driver in FreeBSD. > > > > > >Hey Gleb, > > > > > >Acknowledge... I can do better than that, I have a fix for this problem, > > >and > > >its not temporary. Here is the code change (not a patch, I'm very busy), > > >its in hardware_init, should be obvious how to patch: > > > > > > /* Make sure we have a good EEPROM before we read from it */ > > > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > > > /* > > > ** Some PCI-E parts fail the first check due to > > > ** the link being in sleep state, call it again, > > > ** if it fails a second time its a real issue. > > > */ > > > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > > > device_printf(dev, > > > "The EEPROM Checksum Is Not Valid\n"); > > > return (EIO); > > > } > > > } > > > > > >This is already checked into my code base at Intel, I've just been too > > >busy to do anything with it, be my guest if you wish to check it in after > > >testing... > > > > > >Cheers, > > > > > >Jack > > > > > > > LOL, opps, I just realized, this code reflects the new shared code > > that I am in the process of releasing, in order for this to work in > > 6.2 change 'e1000_validate_nvm_checksum' to > > 'em_validate_eeprom_checksum' and all should be clear :) > > > This worked for me. > > (hoping it will get committed to -STABLE soonish) OK, hint taken, I'll try and get that committed asap. Jack